Skip to content

NO-ISSUE: Robot framework formatter#1920

Merged
openshift-merge-robot merged 3 commits into
openshift:mainfrom
pmtk:robotidy
Jun 20, 2023
Merged

NO-ISSUE: Robot framework formatter#1920
openshift-merge-robot merged 3 commits into
openshift:mainfrom
pmtk:robotidy

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Jun 12, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from dhellmann and ggiguash June 12, 2023 13:44
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@dhellmann
Copy link
Copy Markdown
Contributor

I love it. Let's give some other members of the team a chance to take a look, too.

/assign @pacevedom @jogeo @copejon @eggfoobar

@eggfoobar
Copy link
Copy Markdown
Contributor

Very nice! Do we want to add a quick make file task for it as well?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Jun 19, 2023

Very nice! Do we want to add a quick make file task for it as well?

Added.
Though, I feel like we should organize RF related files (there's some duplication rn in regards to setting up the venv)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2023
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Jun 20, 2023

/retest

@dhellmann
Copy link
Copy Markdown
Contributor

/test images
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 20, 2023

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm f08eb70 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants