Skip to content

[release-4.13] OCPBUGS-14880: Remove config flag externalGatewayInterface from ovn.yaml#1922

Merged
openshift-merge-robot merged 1 commit into
openshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1729-to-release-4.13
Jul 3, 2023
Merged

[release-4.13] OCPBUGS-14880: Remove config flag externalGatewayInterface from ovn.yaml#1922
openshift-merge-robot merged 1 commit into
openshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1729-to-release-4.13

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 13, 2023

This is an automated cherry-pick of #1729

/assign pliurh

@pliurh
Remove config flag externalGatewayInterface from ovn.yaml
802afa8 
This flag is for building a secondary bridge br-ex1 for OVN-K.
The br-ex1 bridge is used by the multiple external gateway feature
that we don't support in microshift.

Signed-off-by: Peng Liu <pliu@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 13, 2023
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 13, 2023

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-13078 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.13] OCPBUGS-14880: Remove config flag externalGatewayInterface from ovn.yaml

Details

In response to this:

This is an automated cherry-pick of #1729

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.13] OCPBUGS-13078: Remove config flag externalGatewayInterface from ovn.yaml [release-4.13] OCPBUGS-14880: Remove config flag externalGatewayInterface from ovn.yaml Jun 13, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 13, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 13, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-14880, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-13078 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-13078 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1729

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from benluddy, dhellmann and jogeo June 13, 2023 01:54
@dhellmann
Copy link
Copy Markdown
Contributor

dhellmann commented Jun 13, 2023

We talked about backporting this on the original ticket.

/label backport-risk-assessed

@pliurh I think you can apply the other labels needed to move this along, so I'll leave it for you to review. Let me know if you need me to give it another nudge.

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 13, 2023
@zshi-redhat
Copy link
Copy Markdown
Contributor

zshi-redhat commented Jun 14, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@pliurh
Copy link
Copy Markdown
Contributor

pliurh commented Jun 15, 2023

/retest

@pliurh
Copy link
Copy Markdown
Contributor

pliurh commented Jun 16, 2023

/label cherry-pick-approved

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 16, 2023

@pliurh: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Copy Markdown
Contributor

zshi-redhat commented Jun 25, 2023

@jogeo can you help on the cherry-pick-approved label?

@dhensel-rh
Copy link
Copy Markdown
Contributor

dhensel-rh commented Jul 3, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 3, 2023
@zshi-redhat
Copy link
Copy Markdown
Contributor

zshi-redhat commented Jul 3, 2023

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 3, 2023
Merged
@openshift-merge-robot openshift-merge-robot merged commit 83f6e5b into openshift:release-4.13 Jul 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 3, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-14880: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14880 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1729

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@benluddy benluddy Awaiting requested review from benluddy

@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees

@zshi-redhat zshi-redhat

@pliurh pliurh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @dhellmann @zshi-redhat @pliurh @dhensel-rh @openshift-merge-robot