Skip to content

USHIFT-1088 Refuse to start if existing data is older than 1 y-stream#1944

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:1088-max-minor-diff
Jun 21, 2023
Merged

USHIFT-1088 Refuse to start if existing data is older than 1 y-stream#1944
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:1088-max-minor-diff

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Jun 21, 2023

No description provided.

@openshift-ci openshift-ci Bot requested review from ggiguash and jogeo June 21, 2023 13:08
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
dhellmann
dhellmann reviewed Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread pkg/admin/prerun/version.go
if execVer.Minor > dataVer.Minor {
if execVer.Minor-1 == dataVer.Minor {
return true, nil
} else {
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this else isn't needed, the code will fall through to the alternative case.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 21, 2023

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm f35ef28 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0d63fa2 into openshift:main Jun 21, 2023
@pmtk pmtk deleted the 1088-max-minor-diff branch June 23, 2023 08:36
This was referenced May 5, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann left review comments

@ggiguash ggiguash Awaiting requested review from ggiguash

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@dhellmann dhellmann

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmtk @dhellmann @openshift-merge-robot