USHIFT-1087 Simple list of blocked upgrades#1949
USHIFT-1087 Simple list of blocked upgrades#1949openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
added
the
approved
pmtk
force-pushed
the
1087-list-of-blocked-upgrades
branch
from
a21e3c8 to
1142724
Compare
|
/cc @dhellmann |
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
| return isBlocked(m, execVersion.String(), dataVersion.String()), nil | ||
| } | ||
|
|
||
| func getBlockedUpgradesAsset() ([]byte, error) { |
There was a problem hiding this comment.
Is using an asset easier to manage than just embedding the list in this go module? Are you thinking of automation managing that file (in which case, yes, I agree YAML is going to be easier)?
There was a problem hiding this comment.
At this point I don't have any idea how we'll use this feature and manage the list. Asset just felt natural since we already embed some files that way but it's not a strong feeling and we can change it
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
No description provided.