Skip to content

USHIFT-1359: Rebase: write cluster registry credentials to custom path#1954

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:rebase-registry-login
Jun 23, 2023
Merged

USHIFT-1359: Rebase: write cluster registry credentials to custom path#1954
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
pmtk:rebase-registry-login

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Jun 23, 2023 •
edited
Loading

Periodic and presubmit jobs are set up differently. oc registry login fails to write registry config to default location in periodic jobs, no problem in presubmits.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2023
@openshift-ci openshift-ci Bot requested review from ggiguash and jerpeter1 June 23, 2023 06:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@pmtk pmtk changed the title WIP rebase: write cluster registry credentials to custom path NO-ISSUE: Rebase: write cluster registry credentials to custom path Jun 23, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2023

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Periodic and presubmit jobs are set up differently.
oc registry login cannot write to default location running in periodic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2023
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2023
@pmtk
write cluster registry credentials to custom path
bec2f55 
Periodic and presubmit jobs are set up differently.
`oc registry login` fails to write registry config
to default location in periodic jobs, no problem
in presubmits.
@pmtk pmtk force-pushed the rebase-registry-login branch from 23f83ab to bec2f55 Compare June 23, 2023 07:37
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Jun 23, 2023

Tested with pj-rehearsals: openshift/release#40589

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2023

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Periodic and presubmit jobs are set up differently. oc registry login fails to write registry config to default location in periodic jobs, no problem in presubmits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the title NO-ISSUE: Rebase: write cluster registry credentials to custom path USHIFT-1359: Rebase: write cluster registry credentials to custom path Jun 23, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2023 •
edited by openshift-ci Bot
Loading

@pmtk: This pull request references USHIFT-1359 which is a valid jira issue.

Details

In response to this:

Periodic and presubmit jobs are set up differently. oc registry login fails to write registry config to default location in periodic jobs, no problem in presubmits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the title USHIFT-1359: Rebase: write cluster registry credentials to custom path USHIFT-1359 Rebase: write cluster registry credentials to custom path Jun 23, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2023

@pmtk: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Periodic and presubmit jobs are set up differently. oc registry login fails to write registry config to default location in periodic jobs, no problem in presubmits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk changed the title USHIFT-1359 Rebase: write cluster registry credentials to custom path USHIFT-1359: Rebase: write cluster registry credentials to custom path Jun 23, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 23, 2023 •
edited by openshift-ci Bot
Loading

@pmtk: This pull request references USHIFT-1359 which is a valid jira issue.

Details

In response to this:

Periodic and presubmit jobs are set up differently. oc registry login fails to write registry config to default location in periodic jobs, no problem in presubmits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann
dhellmann reviewed Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2023

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm bec2f55 link false /test microshift-e2e-arm
ci/prow/e2e-openshift-conformance-reduced-arm bec2f55 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1ea8b5a into openshift:main Jun 23, 2023
@pmtk pmtk deleted the rebase-registry-login branch June 23, 2023 16:20
This was referenced May 5, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann left review comments

@ggiguash ggiguash Awaiting requested review from ggiguash

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@dhellmann dhellmann

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmtk @openshift-ci-robot @dhellmann @openshift-merge-robot