USHIFT-1085: feat: support prerun with minimal services#1978
USHIFT-1085: feat: support prerun with minimal services#1978openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
added function to launch minimal microshift services when needed Signed-off-by: ehila <ehila@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references USHIFT-1085 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
approved
| stop, err := runMinimalMicroshift(pr.config) | ||
| if err != nil { | ||
| return fmt.Errorf("minimal MicroShift run failed to be ready: %w", err) | ||
| } | ||
| defer stop() |
There was a problem hiding this comment.
We can put these lines and L220-L224 to a separate function, like a migrateStorage that would call runMinimalMicroshift() and run the migrator
There was a problem hiding this comment.
Sounds like a plan, do you want me to put that in a separate function in this PR, or do it in #1956 ?
|
/test ? |
|
@pmtk: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test microshift-metal-tests |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Added function to launch minimal MicroShift services when needed. For now the idea is to keep it as a local function for prerun until we need to expose it. I tried to keep it simple at the call site by not sending the channels back to the caller to handle.
This PR supports #1956
/assign @pmtk