Skip to content

WIP. USHIFT-1387: add scenario test run script#1999

Closed
pacevedom wants to merge 3 commits intoopenshift:mainfrom
pacevedom:USHIFT-1387
Closed

WIP. USHIFT-1387: add scenario test run script#1999
pacevedom wants to merge 3 commits intoopenshift:mainfrom
pacevedom:USHIFT-1387

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 5, 2023

@pacevedom: This pull request references USHIFT-1387 which is a valid jira issue.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@pacevedom
Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 5, 2023

@pacevedom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-metal-tests 4309d798c5221ad6e7f1d93c250f0c33ccef10e7 link false /test microshift-metal-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Comment thread test/bin/ci_phase_test.sh Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to override the SCENARIO_INFO_DIR to point to the location in the artifact dir where the scenario data has been downloaded in the previous step. We might need a new variable in common.sh to make overriding all of the other directory variables easier.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, was just creating this commit to check whats needed from openshift/release and work it out from that starting point.
Base path for everything will also change once the microshift-test-payload image disappears, so we need to make it configurable in an easy way. Thanks for the heads up!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the artifact dir shared between pods in the CI cluster? Or should we use the shared directory and then copy the content into the artifact directory separately?

Comment thread test/bin/scenario.sh Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this in the scenario script because in CI several copies of this will eventually run in parallel. We could do it explicitly in the phase script instead.

@pacevedom pacevedom force-pushed the USHIFT-1387 branch 3 times, most recently from c051d0d to c113646 Compare July 7, 2023 14:33
@pacevedom pacevedom force-pushed the USHIFT-1387 branch 8 times, most recently from a8f0c72 to ff61466 Compare July 11, 2023 06:56
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@pacevedom pacevedom closed this Jul 11, 2023
@pacevedom pacevedom deleted the USHIFT-1387 branch July 12, 2023 10:43
@pacevedom pacevedom restored the USHIFT-1387 branch July 12, 2023 14:17
@pacevedom pacevedom deleted the USHIFT-1387 branch December 18, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants