Skip to content

USHIFT-1401: rebase should only clean up files it creates#2004

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1401-rebase-clean-less-aggressively
Jul 7, 2023
Merged

USHIFT-1401: rebase should only clean up files it creates#2004
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1401-rebase-clean-less-aggressively

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

We use the _output directory for tools and test files, which should
not be deleted when running a rebase.

/assign @pmtk

We use the _output directory for tools and test files, which should
not be deleted when running a rebase.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 6, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 6, 2023

@dhellmann: This pull request references USHIFT-1401 which is a valid jira issue.

Details

In response to this:

We use the _output directory for tools and test files, which should
not be deleted when running a rebase.

/assign @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from pacevedom and pmtk July 6, 2023 15:19
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 6, 2023

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 3ba706c link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jul 7, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants