USHIFT-1085: Storage Migration Controller Implementation

[eggfoobar]

This PR builds upon the work done in the previous PR #1956 but with the cluster fully running instead of pre-run.

This was done since we need the cluster to be fully running with the kubelet in order to guarantee migrations for CRD Migration Webhooks.

/cc @dhellmann

[openshift-ci-robot]

@eggfoobar: This pull request references USHIFT-1085 which is a valid jira issue.

Details

In response to this:

This PR builds upon the work done in the previous PR #1956 but with the cluster fully running instead of pre-run.

This was done since we need the cluster to be fully running with the kubelet in order to guarantee migrations for CRD Migration Webhooks.

/cc @dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

What's the difference between the trigger and the migrator?

[pmtk]

There's user guide for it'd be nice to include that information in our repository (even as a comment in one of the files).

Looks like we'll need to include checking if migration is complete and successful in healthcheck script

[pmtk]

And we'll need to rethink $DATA_DIR/version - current impl was based on assumption that migration would happen before "true" start, but with this we'll just start and healthcheck will assess if all is good.
Maybe it's a good thing and will simplify and increase flexibility of the upgradability. 🤔

[pmtk]

To make test-rebase happy I think you need ignore: "REASON" to the files you added in assets.yaml

[pmtk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [eggfoobar,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD af0c3f8 and 2 for PR HEAD 3f9fa92 in total

[openshift-ci]

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm	3f9fa92	link	false	/test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.