USHIFT-1413: Update prerun after storage migration design changes#2037
USHIFT-1413: Update prerun after storage migration design changes#2037openshift-merge-robot merged 3 commits intoopenshift:mainfrom
Conversation
|
@pmtk: This pull request references USHIFT-1413 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Maybe calling it something like checkVersionCompatibility might be better here.
Also the comment should remove reference to the bool return type.
There was a problem hiding this comment.
Thanks for catching that! Fixed
dhellmann
left a comment
There was a problem hiding this comment.
This looks good, aside from @eggfoobar's comment.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@pmtk: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We won't aim toward running migration in prerun phase (instead it'll run in full cluster).
Therefore, removing all references to migration from prerun.
It can be now thought of as two, almost distinct, areas: