Skip to content

USHIFT-1413: Update prerun after storage migration design changes#2037

Merged
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
pmtk:1413-split-prerun
Jul 12, 2023
Merged

USHIFT-1413: Update prerun after storage migration design changes#2037
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
pmtk:1413-split-prerun

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Jul 11, 2023

We won't aim toward running migration in prerun phase (instead it'll run in full cluster).
Therefore, removing all references to migration from prerun.
It can be now thought of as two, almost distinct, areas:

  • data management (backup, restore, removal), and
  • version metadata management

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 11, 2023

@pmtk: This pull request references USHIFT-1413 which is a valid jira issue.

Details

In response to this:

We won't aim toward running migration in prerun phase (instead it'll run in full cluster).
Therefore, removing all references to migration from prerun.
It can be now thought of as two, almost distinct, areas:

  • data management (backup, restore, removal), and
  • version metadata management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from copejon and pacevedom July 11, 2023 12:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

Comment thread pkg/admin/prerun/version.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe calling it something like checkVersionCompatibility might be better here.

Also the comment should remove reference to the bool return type.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Fixed

Copy link
Copy Markdown
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, aside from @eggfoobar's comment.

@pmtk pmtk force-pushed the 1413-split-prerun branch from 48688dd to 2e3e4f3 Compare July 12, 2023 07:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@pmtk pmtk force-pushed the 1413-split-prerun branch from 2e3e4f3 to 6ba6398 Compare July 12, 2023 07:20
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@eggfoobar
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Jul 12, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit f206b35 into openshift:main Jul 12, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 12, 2023

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 6ba6398 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants