Skip to content

USHIFT-1859: Kustomization: enable server-side apply to avoid big resources failing#2536

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jmprusi:jmprusi/kustomization-server-side-apply
Nov 7, 2023
Merged

USHIFT-1859: Kustomization: enable server-side apply to avoid big resources failing#2536
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jmprusi:jmprusi/kustomization-server-side-apply

Conversation

@jmprusi
Copy link
Copy Markdown
Contributor

@jmprusi jmprusi commented Oct 31, 2023

Enables server-side apply for kustomize at startup. related to #2535

Which issue(s) this PR addresses:

Closes #2535

@openshift-ci openshift-ci Bot requested review from jerpeter1 and pacevedom October 31, 2023 13:11
@dhellmann
Copy link
Copy Markdown
Contributor

@jmprusi The change looks good, but we're going to want a jira ticket to ensure we get a release note for the new behavior. Can you work with @pacevedom to set that up, please?

/retest

@dhellmann
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
In order to avoid big resources failing to get applied, this commit
enables the server-side apply and also the force-conflicts flag to
ensure that the previous behaviour is mantained.

Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
@jmprusi jmprusi force-pushed the jmprusi/kustomization-server-side-apply branch from 2abb1c6 to 4edccd7 Compare November 2, 2023 10:52
@jmprusi
Copy link
Copy Markdown
Contributor Author

jmprusi commented Nov 2, 2023

@dhellmann I've updated the PR to properly maintain the old behavior to avoid issues with current microshift users. PTAL.

I will ping @pacevedom to get the proper Jira ticket created.

Thanks.

@jmprusi
Copy link
Copy Markdown
Contributor Author

jmprusi commented Nov 6, 2023

/retest

@pacevedom
Copy link
Copy Markdown
Contributor

pacevedom commented Nov 7, 2023

/retitle USHIFT-1859: Kustomization: enable server-side apply to avoid big resources failing

@openshift-ci openshift-ci Bot changed the title Kustomization: enable server-side apply to avoid big resources failing USHIFT-1859: Kustomization: enable server-side apply to avoid big resources failing Nov 7, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 7, 2023

@jmprusi: This pull request references USHIFT-1859 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Enables server-side apply for kustomize at startup. related to #2535

Which issue(s) this PR addresses:

Closes #2535

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, jmprusi, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 9017609 into openshift:main Nov 7, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 7, 2023

@jmprusi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/metal-periodic-test-arm 4edccd7 link true /test metal-periodic-test-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Big resources fail to be applied by kustomize at startup.

4 participants