Skip to content

Create RPM SELinux sub-module#291

Merged
rootfs merged 1 commit intoopenshift:mainfrom
mangelajo:selinux-rpm-spec
Sep 21, 2021
Merged

Create RPM SELinux sub-module#291
rootfs merged 1 commit intoopenshift:mainfrom
mangelajo:selinux-rpm-spec

Conversation

@mangelajo
Copy link
Copy Markdown
Contributor

@mangelajo mangelajo commented Sep 21, 2021 •
edited
Loading

Adds a Makefile for the selinux directory to help with local development
and adds an selinux microshift sub-package which contains the selinux
policies.

Related-Issue: #277

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

@mangelajo
Create RPM SELinux sub-module
cca0aa3 
Adds a Makefile for the selinux directory to help with local development
and adds an selinux microshift sub-package which contains the selinux
policies.

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
@openshift-ci openshift-ci Bot requested review from copejon and fzdarsky September 21, 2021 13:47
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 21, 2021

Hi @mangelajo. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mangelajo
Copy link
Copy Markdown
Contributor Author

mangelajo commented Sep 21, 2021

@rootfs @cooktheryan ^ 🥳 🥳

@rootfs
Copy link
Copy Markdown
Contributor

rootfs commented Sep 21, 2021

/lgtm

@rootfs
Copy link
Copy Markdown
Contributor

rootfs commented Sep 21, 2021

/assign @cooktheryan

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2021
@cooktheryan
Copy link
Copy Markdown
Contributor

cooktheryan commented Sep 21, 2021

/LGTM

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cooktheryan, rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rootfs rootfs merged commit cfce7a2 into openshift:main Sep 21, 2021
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@fzdarsky fzdarsky Awaiting requested review from fzdarsky

Assignees

@cooktheryan cooktheryan

@rootfs rootfs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangelajo @rootfs @cooktheryan