Skip to content

USHIFT-2229: Test Multus - ipvlan CNI#3156

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:multus/test/ipvlan
Apr 3, 2024
Merged

USHIFT-2229: Test Multus - ipvlan CNI#3156
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:multus/test/ipvlan

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Mar 14, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 14, 2024 •
edited by openshift-ci Bot
Loading

@pmtk: This pull request references USHIFT-2229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Mar 14, 2024

/test ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 14, 2024

@pmtk: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Mar 14, 2024

/test metal-periodic-test microshift-metal-tests-arm

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Mar 14, 2024

Depends on #3155

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Mar 14, 2024

/test metal-periodic-test microshift-metal-tests-arm

@pmtk pmtk force-pushed the multus/test/ipvlan branch from 5e6895e to 621f574 Compare March 14, 2024 15:47
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Mar 14, 2024

/test metal-periodic-test microshift-metal-tests-arm

@pmtk pmtk force-pushed the multus/test/ipvlan branch from 621f574 to efc235c Compare March 28, 2024 14:15
@pmtk pmtk marked this pull request as ready for review March 28, 2024 14:15
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@openshift-ci openshift-ci Bot requested review from copejon and pacevedom March 28, 2024 14:16
ggiguash
ggiguash reviewed Apr 3, 2024
View reviewed changes
Comment thread test/bin/manage_hypervisor_config.sh Outdated
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to make this code more generic. Here's what I have on my machine as a range.

$ sudo virsh net-dumpxml default | grep -A4 'ip address'
  <ip address='192.168.100.1' netmask='255.255.255.0' localPtr='yes'>
    <dhcp>
      <range start='192.168.100.100' end='192.168.100.254'/>
    </dhcp>
  </ip>

Copy link
Copy Markdown
Contributor

@ggiguash ggiguash Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have an isolated-network.xml, which we define for a special case.
I would add a special case new network for this test, rather than changing the default.

Copy link
Copy Markdown
Member Author

@pmtk pmtk Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed according to the suggestion

@pmtk pmtk force-pushed the multus/test/ipvlan branch from efc235c to 13d2b61 Compare April 3, 2024 10:32
@pmtk pmtk force-pushed the multus/test/ipvlan branch from 13d2b61 to 771c4e3 Compare April 3, 2024 12:52
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Apr 3, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 3, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit aef0f29 into openshift:main Apr 3, 2024
@pmtk pmtk deleted the multus/test/ipvlan branch May 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggiguash ggiguash ggiguash left review comments

@copejon copejon Awaiting requested review from copejon

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmtk @openshift-ci-robot @ggiguash