USHIFT-2992: Image builder cleanup: don't stop osbuild-composer.socket#3271
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request references USHIFT-2992 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
There was a problem hiding this comment.
Why did we remove --now? Does it have no effect during stop?
There was a problem hiding this comment.
--now is only meaningful for enable and disable and results in immediate start (enable) and stop (disable)
There was a problem hiding this comment.
Can we add a comment about stopping osbuild-composer.socket here?
There was a problem hiding this comment.
Should the start order be inverted here as we're first stopping workers now?
There was a problem hiding this comment.
Actually I found that we don't even need to start composer. Thanks to the socket, starting workers will cause composer to start but left it just in case
There was a problem hiding this comment.
Can we add a comment about this?
pmtk
force-pushed
the
rhel94/image-builder-cleanup-dont-stop-socket
branch
from
8769dbf to
821218c
Compare
…failing Disabling socket can cause composer to fail the shutdown and result in multiple restarts that fail and block later start (at the end of the script). Instead, stop workers first to keep composer from reactivating via socket, then stop the composer.
pmtk
force-pushed
the
rhel94/image-builder-cleanup-dont-stop-socket
branch
from
821218c to
f5f43f9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Disabling socket can cause composer to fail the shutdown and result in multiple restarts that fail and block later start (at the end of the script).
Instead, stop workers first to keep composer from reactivating via socket, then stop the composer.