Skip to content

OCPBUGS-30039: Switch to registry.redhat.io images for OpenSSL dependency in TopoLVM#3340

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:openssl_image
May 10, 2024
Merged

OCPBUGS-30039: Switch to registry.redhat.io images for OpenSSL dependency in TopoLVM#3340
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ggiguash:openssl_image

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented May 9, 2024

Also switched to the latest ubi9 image.

Note that neither ubi9-minimal nor ubi9-micro contain the openssl executable we need.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 9, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 9, 2024

@ggiguash: This pull request references Jira Issue OCPBUGS-30039, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Also switched to the latest ubi9 image.

Note that neither ubi9-minimal nor ubi9-micro contain the openssl executable we need.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jerpeter1, jogeo and pacevedom May 9, 2024 14:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented May 9, 2024

/test ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 9, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus-arm
  • pull-ci-openshift-microshift-main-test-rebase
  • pull-ci-openshift-microshift-main-test-rpm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented May 9, 2024

/test metal-periodic-test
/test metal-periodic-test-arm
/test metal-bootc-test
/test metal-bootc-test-arm

pacevedom
pacevedom reviewed May 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
Holding for now, if you want to we can unhold it and handle this file in a different PR?

Comment thread packaging/images/openshift-ci/Dockerfile.test-runtime Outdated
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented May 10, 2024

Removed the problematic change. Unholding
/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
pacevedom
pacevedom reviewed May 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Copy Markdown
Contributor Author

ggiguash commented May 10, 2024

/test metal-periodic-test
/test metal-periodic-test-arm
/test metal-bootc-test
/test metal-bootc-test-arm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 10, 2024

/retest-required

Remaining retests: 0 against base HEAD 64d6a93 and 2 for PR HEAD 40b3124 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 1407777 into openshift:main May 10, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 10, 2024

@ggiguash: Jira Issue OCPBUGS-30039: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30039 has been moved to the MODIFIED state.

Details

In response to this:

Also switched to the latest ubi9 image.

Note that neither ubi9-minimal nor ubi9-micro contain the openssl executable we need.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash deleted the openssl_image branch May 10, 2024 14:45
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Jul 12, 2024
Merged
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Jul 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

1 more reviewer

@pacevedom pacevedom pacevedom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ggiguash @openshift-ci-robot @pacevedom @openshift-merge-robot