Skip to content

[release-4.16] USHIFT-3272: audit log defaults fix#3417

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.16from
openshift-cherrypick-robot:cherry-pick-3365-to-release-4.16
May 31, 2024
Merged

[release-4.16] USHIFT-3272: audit log defaults fix#3417
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.16from
openshift-cherrypick-robot:cherry-pick-3365-to-release-4.16

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 31, 2024

This is an automated cherry-pick of #3365

/assign copejon

copejon added 2 commits May 31, 2024 03:40
@copejon
kube-apiserver auditlog values were not given microshift's defaults a…
1777666 
…nd thus did not produce behavior described by microshift documentation regarding log retention settings. default values are not specified correctly

Signed-off-by: Jon Cope <jcope@redhat.com>
@copejon
align the default values to those specified in the original enhanceme…
8fa6fff 
…nt proposal and microshift documentation

Signed-off-by: Jon Cope <jcope@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 31, 2024
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 31, 2024 •
edited by openshift-ci Bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: USHIFT-3164

Details

In response to this:

This is an automated cherry-pick of #3365

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from ggiguash and pacevedom May 31, 2024 03:40
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 31, 2024 •
edited by openshift-ci Bot
Loading

/retitle [release-4.16] USHIFT-3272: audit log defaults fix
/lgtm

@openshift-ci openshift-ci Bot changed the title [release-4.16] USHIFT-3164: audit log defaults fix [release-4.16] USHIFT-3272: audit log defaults fix May 31, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 31, 2024 •
edited by openshift-ci Bot
Loading

@openshift-cherrypick-robot: This pull request references USHIFT-3272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead.

Details

In response to this:

This is an automated cherry-pick of #3365

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2024
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 31, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 31, 2024
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 31, 2024

/label jira/valid-bug

@openshift-ci openshift-ci Bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 31, 2024
@gangwgr
Copy link
Copy Markdown

gangwgr commented May 31, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 31, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 20059db into openshift:release-4.16 May 31, 2024
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@pacevedom pacevedom Awaiting requested review from pacevedom

Assignees

@copejon copejon

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @ggiguash @gangwgr @copejon