Skip to content

NO-ISSUE: Add 4.15 rhocp repo to configure-vm.sh#3557

Closed
pacevedom wants to merge 3 commits intoopenshift:release-4.16from
pacevedom:repo-4.15
Closed

NO-ISSUE: Add 4.15 rhocp repo to configure-vm.sh#3557
pacevedom wants to merge 3 commits intoopenshift:release-4.16from
pacevedom:repo-4.15

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

Manually add this repo to the configure-vm.sh script. The get_latest_rhocp_repo has been returning 4.15 and inadvertently enabling that repo until 4.16 went GA and the repo was publicly available. Now that this is the case, the scenario preparation for upgrade tests fails, as there is no repo configured to pull those packages.
This PR fixes that by adding not just 4.16 repo, but also 4.15. This is a manual cherry-pick of #3556

Which issue(s) this PR addresses:

Closes #

Manually add this repo to the configure-vm.sh script. The
get_latest_rhocp_repo has been returning 4.15 and inadvertently
enabling that repo until 4.16 went GA and the repo was publicly
available. Now that this is the case, the scenario preparation for
upgrade tests fails, as there is no repo configured to pull those
packages.
This PR fixes that by adding not just 4.16 repo, but also 4.15.
This is a manual cherry-pick of openshift#3556
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@pacevedom: This pull request explicitly references no jira issue.

Details

In response to this:

Manually add this repo to the configure-vm.sh script. The get_latest_rhocp_repo has been returning 4.15 and inadvertently enabling that repo until 4.16 went GA and the repo was publicly available. Now that this is the case, the scenario preparation for upgrade tests fails, as there is no repo configured to pull those packages.
This PR fixes that by adding not just 4.16 repo, but also 4.15. This is a manual cherry-pick of #3556

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jerpeter1 and pliurh June 28, 2024 17:01
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@copejon
Copy link
Copy Markdown
Contributor

copejon commented Jun 28, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@pacevedom
Copy link
Copy Markdown
Contributor Author

/hold
rpm-install needs to update repos, as it does not get the right one now.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2024
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 28, 2024

New changes are detected. LGTM label has been removed.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/test microshift-metal-tests

@pacevedom pacevedom force-pushed the repo-4.15 branch 3 times, most recently from 5a7e959 to b6af126 Compare July 1, 2024 12:14
@pacevedom
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jul 1, 2024

I believe this will conflict with: #3513 (in which the tests are passing so it should be fixing the issue present on release-4.16 branch)

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jul 1, 2024

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 1, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/close

@openshift-ci openshift-ci Bot closed this Jul 1, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 1, 2024

@pacevedom: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants