Tune design#365
Conversation
|
Hi @iranzo. Thanks for your PR. I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign rootfs |
There was a problem hiding this comment.
it looks just some format fixes, are there any material changes?
There was a problem hiding this comment.
Because the "title" already contains this and will show as two h1 elements in the rendered page
|
/approve |
|
@iranzo thanks, do you have a preview we can see the final rendering? |
|
I have added netlify to build docs/ previews, but not sure how to trigger it on a existing PR. |
|
@iranzo can you try to force-push to see if netlify.com will trigger on your PR? |
|
✔️ Deploy Preview for microshift canceled. 🔨 Explore the source changes: 0ad4f8d 🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6176b2093dbcaff4d07cae7a |
|
Done |
|
/lgtm |
|
thanks @iranzo it looks great |
Thanks, it's just some basic tuning to get it looking better on the rendered site, but using a stock theme + admonitions (check the 'note' in the index page for example) and some other stuff for SEO (keywords, sitemap, twitter cards, etc) If you later get OSPO to design a UI there will be other stuff to request :) |
BTW you can tune the domain used so instead of 'trusting-wilson' it says something like microshif on netlify site, for example in kubevirt: https://deploy-preview-807--kubevirtio.netlify.app/ |
|
done, I guess it will be effective on next push, https://microshift.netlify.app/ |
Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mangelajo, rootfs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Yup, actual URL: https://deploy-preview-365--microshift.netlify.app/ |
|
yup it seems to work, canceled because: |
This tunes microshift.io design and pages to better show on the browser