Skip to content

Tune design#365

Merged
rootfs merged 1 commit intoopenshift:mainfrom
iranzo:tune
Oct 25, 2021
Merged

Tune design#365
rootfs merged 1 commit intoopenshift:mainfrom
iranzo:tune

Conversation

@iranzo
Copy link
Copy Markdown
Member

@iranzo iranzo commented Oct 25, 2021

This tunes microshift.io design and pages to better show on the browser

@openshift-ci openshift-ci Bot requested review from copejon and husky-parul October 25, 2021 09:16
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

Hi @iranzo. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2021
@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 25, 2021

/assign rootfs

Comment thread docs/design/design.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks just some format fixes, are there any material changes?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the "title" already contains this and will show as two h1 elements in the rendered page

@rootfs
Copy link
Copy Markdown
Contributor

rootfs commented Oct 25, 2021

/approve
/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@rootfs
Copy link
Copy Markdown
Contributor

rootfs commented Oct 25, 2021

@iranzo thanks, do you have a preview we can see the final rendering?

@mangelajo
Copy link
Copy Markdown
Contributor

I have added netlify to build docs/ previews, but not sure how to trigger it on a existing PR.

@mangelajo
Copy link
Copy Markdown
Contributor

@iranzo can you try to force-push to see if netlify.com will trigger on your PR?

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 25, 2021

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: 0ad4f8d

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6176b2093dbcaff4d07cae7a

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 25, 2021

Done

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 25, 2021

https://deploy-preview-365--trusting-wilson-e71455.netlify.app/

@rootfs @mangelajo

@mangelajo
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@mangelajo
Copy link
Copy Markdown
Contributor

thanks @iranzo it looks great

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 25, 2021

thanks @iranzo it looks great

Thanks, it's just some basic tuning to get it looking better on the rendered site, but using a stock theme + admonitions (check the 'note' in the index page for example) and some other stuff for SEO (keywords, sitemap, twitter cards, etc)

If you later get OSPO to design a UI there will be other stuff to request :)

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 25, 2021

I have added netlify to build docs/ previews, but not sure how to trigger it on a existing PR.

BTW you can tune the domain used so instead of 'trusting-wilson' it says something like microshif on netlify site, for example in kubevirt: https://deploy-preview-807--kubevirtio.netlify.app/

@mangelajo
Copy link
Copy Markdown
Contributor

done, I guess it will be effective on next push, https://microshift.netlify.app/

Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@mangelajo
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo, rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 25, 2021

@mangelajo
Copy link
Copy Markdown
Contributor

yup it seems to work, canceled because: 3:33:12 PM: Failed during stage 'checking build content for changes': Canceled build due to no content change 3:33:12 PM: Finished processing build request in 11.997644152s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants