Skip to content

USHIFT-706: Add CSI Deployment Flag and Config#3678

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
copejon:ushift-706
Aug 9, 2024
Merged

USHIFT-706: Add CSI Deployment Flag and Config#3678
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
copejon:ushift-706

Conversation

@copejon
Copy link
Copy Markdown
Contributor

@copejon copejon commented Jul 24, 2024 •
edited
Loading

Definition of Done:

  • Feature implementation complete
  • Added test scenarios to test workflows described by the EP
  • Added unit-tests as necessary
  • Repo documentation is updated and Docs team has reviewed the changes TBD in separate PR

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2024
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 24, 2024 •
edited by openshift-ci Bot
Loading

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Definition of Done:

  • Feature implementation complete
  • Added test scenarios to test workflows described by the EP
  • Added unit-tests as necessary
  • Repo documentation is updated and Docs team has reviewed the changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@copejon copejon marked this pull request as ready for review July 30, 2024 23:00
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@openshift-ci openshift-ci Bot requested review from pacevedom and pmtk July 30, 2024 23:00
pmtk
pmtk reviewed Aug 1, 2024
View reviewed changes
Comment thread packaging/greenboot/microshift-running-check.sh Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/storage.go Outdated
Comment thread pkg/config/storage.go Outdated
Comment thread pkg/config/storage.go Outdated
Comment thread test/suites/standard1/configuration.robot Outdated
Comment thread test/suites/standard1/configuration.robot Outdated
pacevedom
pacevedom reviewed Aug 1, 2024
View reviewed changes
Comment thread packaging/greenboot/microshift-running-check.sh Outdated
Comment thread pkg/config/storage.go Outdated
Comment thread pkg/config/config_test.go Outdated
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
@copejon copejon force-pushed the ushift-706 branch 3 times, most recently from f473f84 to ea0305b Compare August 5, 2024 18:30
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci Bot
Loading

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Definition of Done:

  • Feature implementation complete
  • Added test scenarios to test workflows described by the EP
  • Added unit-tests as necessary
  • Repo documentation is updated and Docs team has reviewed the changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci Bot
Loading

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Definition of Done:

  • Feature implementation complete
  • Added test scenarios to test workflows described by the EP
  • Added unit-tests as necessary
  • Repo documentation is updated and Docs team has reviewed the changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci Bot
Loading

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Definition of Done:

  • Feature implementation complete
  • Added test scenarios to test workflows described by the EP
  • Added unit-tests as necessary
  • Repo documentation is updated and Docs team has reviewed the changes TBD in separate PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread cmd/generate-config/config/config-openapi-spec.json Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread cmd/generate-config/config/config-openapi-spec.json Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread test/suites/tuned/microshift-tuned.robot Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread packaging/microshift/config.yaml Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread pkg/components/csi-snapshot-controller.go Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread cmd/generate-config/config/config-openapi-spec.json Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread cmd/generate-config/config/config-openapi-spec.json Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread test/suites/standard1/configuration.robot Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread packaging/greenboot/microshift-running-check.sh Outdated
ggiguash
ggiguash reviewed Aug 7, 2024
View reviewed changes
Comment thread packaging/greenboot/microshift-running-check.sh Outdated
pacevedom
pacevedom reviewed Aug 7, 2024
View reviewed changes
Comment thread pkg/config/storage.go Outdated
Comment thread test/resources/oc.resource Outdated
Comment thread test/suites/standard1/configuration.robot Outdated
Comment thread pkg/components/storage.go Outdated
ggiguash
ggiguash reviewed Aug 8, 2024
View reviewed changes
Comment thread packaging/greenboot/functions.sh Outdated
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Aug 8, 2024

/test all

@pacevedom
Copy link
Copy Markdown
Contributor

pacevedom commented Aug 8, 2024

/retest-required

pmtk
pmtk reviewed Aug 8, 2024
View reviewed changes
Comment thread pkg/config/config.go Outdated
Comment thread cmd/generate-config/config/config-openapi-spec.json Outdated
Comment thread packaging/greenboot/functions.sh Outdated
Comment thread packaging/greenboot/functions.sh Outdated
Comment thread packaging/greenboot/functions.sh Outdated
Comment thread packaging/greenboot/microshift-running-check.sh Outdated
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 8, 2024 •
edited by openshift-ci Bot
Loading

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Definition of Done:

  • Feature implementation complete
  • Added test scenarios to test workflows described by the EP
  • Added unit-tests as necessary
  • Repo documentation is updated and Docs team has reviewed the changes TBD in separate PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon
implementation of Optional CSI Config: openshift/enhancements#1635
f3d97c9 
expand microshift config with new storage root field. allows users to disable LVMS and/or CSI components

Signed-off-by: Jon Cope <jcope@redhat.com>
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Aug 8, 2024

squashed commit history

@pacevedom
Copy link
Copy Markdown
Contributor

pacevedom commented Aug 9, 2024

lgtm, I will let others label it

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Aug 9, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit a4d1ad9 into openshift:main Aug 9, 2024
@copejon copejon deleted the ushift-706 branch August 9, 2024 16:36
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Aug 9, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Aug 9, 2024

@copejon: new pull request created: #3748

Details

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 9, 2024
Merged
This was referenced Oct 27, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@pmtk pmtk pmtk left review comments

@pacevedom pacevedom pacevedom left review comments

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pmtk pmtk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@copejon @openshift-ci-robot @ggiguash @pacevedom @pmtk @openshift-cherrypick-robot @openshift-merge-robot