Skip to content

USHIFT-3772: Dual stack RF e2e tests#3681

Merged
openshift-merge-bot[bot] merged 8 commits intoopenshift:mainfrom
pacevedom:USHIFT-3772
Aug 1, 2024
Merged

USHIFT-3772: Dual stack RF e2e tests#3681
openshift-merge-bot[bot] merged 8 commits intoopenshift:mainfrom
pacevedom:USHIFT-3772

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom commented Jul 25, 2024

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 25, 2024 •
edited by openshift-ci Bot
Loading

@pacevedom: This pull request references USHIFT-3772 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2024
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 25, 2024

/hold
Depends on #3676

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2024
@openshift-ci openshift-ci Bot requested review from ggiguash and pliurh July 25, 2024 21:31
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 27, 2024

/retest-required

@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 29, 2024

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 29, 2024

/retest-required

pmtk
pmtk reviewed Jul 30, 2024
View reviewed changes
Comment thread test/suites/ipv6/dualstack.robot Outdated
Comment on lines 33 to 34
Copy link
Copy Markdown
Member

@pmtk pmtk Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies in code below as well

Suggested change
${pod_ip}= Run With Kubeconfig
... oc get pod hello-microshift -n ${NAMESPACE} -o jsonpath='{.status.podIPs[0].ip}'
${pod_ip}= Oc Get JsonPath pod ${NAMESPACE} hello-microshift .status.podIPs[0].ip

Copy link
Copy Markdown
Contributor Author

@pacevedom pacevedom Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread test/suites/ipv6/dualstack.robot Outdated
Comment thread test/suites/ipv6/dualstack.robot Outdated
Comment thread test/suites/ipv6/dualstack.robot Outdated
Comment thread test/suites/ipv6/dualstack.robot Outdated
Comment thread test/suites/ipv6/dualstack.robot Outdated
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 31, 2024

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
pmtk
pmtk reviewed Jul 31, 2024
View reviewed changes
Comment thread test/suites/ipv6/dualstack.robot Outdated
pmtk
pmtk reviewed Jul 31, 2024
View reviewed changes
Comment thread test/suites/ipv6/dualstack.robot Outdated
@pacevedom
Copy link
Copy Markdown
Contributor Author

pacevedom commented Jul 31, 2024

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Aug 1, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 1, 2024

/retest-required

Remaining retests: 0 against base HEAD 9f1f525 and 2 for PR HEAD 6ef994f in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f32bd0d into openshift:main Aug 1, 2024
This was referenced Oct 27, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@pliurh pliurh Awaiting requested review from pliurh

1 more reviewer

@pmtk pmtk pmtk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pmtk pmtk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pacevedom @openshift-ci-robot @pmtk