Skip to content

Refactor kube-controller-manager config#371

Merged
fzdarsky merged 1 commit intomainfrom
refactor-kube-controller-manager-config
Oct 27, 2021
Merged

Refactor kube-controller-manager config#371
fzdarsky merged 1 commit intomainfrom
refactor-kube-controller-manager-config

Conversation

@fzdarsky
Copy link
Copy Markdown
Contributor

Removes no longer used config.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 26, 2021

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: 5f6c8b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6177bf78e4b5730008da3dae

@openshift-ci openshift-ci Bot requested review from copejon and rootfs October 26, 2021 08:11
Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@fzdarsky fzdarsky force-pushed the refactor-kube-controller-manager-config branch from 9dd16d9 to 5f6c8b8 Compare October 26, 2021 08:42
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

@fzdarsky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-auth 5f6c8b8 link false /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-openshift-conformance-sig-network 5f6c8b8 link false /test e2e-openshift-conformance-sig-network
ci/prow/e2e-openshift-conformance-sig-storage 5f6c8b8 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-api-machinery 5f6c8b8 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom sallyom self-assigned this Oct 27, 2021
@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented Oct 27, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@fzdarsky fzdarsky merged commit 5fd1b58 into main Oct 27, 2021
@fzdarsky fzdarsky deleted the refactor-kube-controller-manager-config branch October 27, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants