Skip to content

Refactor kube-scheduler config#372

Merged
cooktheryan merged 1 commit intomainfrom
refactor-kube-scheduler-config
Oct 27, 2021
Merged

Refactor kube-scheduler config#372
cooktheryan merged 1 commit intomainfrom
refactor-kube-scheduler-config

Conversation

@fzdarsky
Copy link
Copy Markdown
Contributor

@fzdarsky fzdarsky commented Oct 26, 2021

Consolidates configuration of kube-scheduler into single location.

@openshift-ci openshift-ci Bot requested review from husky-parul and rootfs October 26, 2021 08:32
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 26, 2021 •
edited
Loading

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: ec09bbe

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6177bee7a65b6e000880b6fe

@fzdarsky
Consolidate kube-scheduler config
ec09bbe 
Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@fzdarsky fzdarsky force-pushed the refactor-kube-scheduler-config branch from 9b3798b to ec09bbe Compare October 26, 2021 08:40
husky-parul
husky-parul approved these changes Oct 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@husky-parul husky-parul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: husky-parul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2021
@husky-parul
Copy link
Copy Markdown
Contributor

husky-parul commented Oct 26, 2021

/retest

1 similar comment
@copejon
Copy link
Copy Markdown
Contributor

copejon commented Oct 26, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

@fzdarsky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-api-machinery ec09bbe link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cooktheryan cooktheryan merged commit fe1fc55 into main Oct 27, 2021
@cooktheryan cooktheryan deleted the refactor-kube-scheduler-config branch October 27, 2021 00:17
@microshift-rebase-script microshift-rebase-script Bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rootfs rootfs Awaiting requested review from rootfs

1 more reviewer

@husky-parul husky-parul husky-parul approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@husky-parul husky-parul

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fzdarsky @husky-parul @copejon @cooktheryan