Skip to content

Refactor openshift-apiserver and -controller-manager configs#376

Merged
fzdarsky merged 1 commit intomainfrom
refactor-ocp-controllers-config
Oct 27, 2021
Merged

Refactor openshift-apiserver and -controller-manager configs#376
fzdarsky merged 1 commit intomainfrom
refactor-ocp-controllers-config

Conversation

@fzdarsky
Copy link
Copy Markdown
Contributor

Consolidates configuration of openshift-apiserver and openshift-controller-manager into single locations.

Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com

@openshift-ci openshift-ci Bot requested review from mangelajo and rootfs October 26, 2021 11:25
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 26, 2021

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: b049be5

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/61792b81a27327000806f02f

@fzdarsky fzdarsky changed the title Consolidate openshift-apiserver and -controller-manager configs Refactor openshift-apiserver and -controller-manager configs Oct 26, 2021
@rootfs
Copy link
Copy Markdown
Contributor

rootfs commented Oct 26, 2021

need a rebase, then lgtm

@copejon
Copy link
Copy Markdown
Contributor

copejon commented Oct 26, 2021

/retest

Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@fzdarsky fzdarsky force-pushed the refactor-ocp-controllers-config branch from 4171fe9 to b049be5 Compare October 27, 2021 10:35
@husky-parul
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2021
@husky-parul
Copy link
Copy Markdown
Contributor

/retest

@husky-parul
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: husky-parul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

@fzdarsky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-api-machinery b049be5 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants