Skip to content

Fix protoc-gen-go/generator deprecation warning#377

Merged
rootfs merged 1 commit intomainfrom
fix-366-generator-deprecated-warning
Oct 27, 2021
Merged

Fix protoc-gen-go/generator deprecation warning#377
rootfs merged 1 commit intomainfrom
fix-366-generator-deprecated-warning

Conversation

@fzdarsky
Copy link
Copy Markdown
Contributor

@fzdarsky fzdarsky commented Oct 26, 2021

Bumps grpc-gateway version from v1.9.5 to v1.11.3 to remove the warning
of protoc-gen-go/generator being deprecated.

Signed-off-by: Frank A. Zdarsky fzdarsky@redhat.com

Closes #366

@fzdarsky
Bump grpc-gateway version
7e645e7 
Bumps grpc-gateway version from v1.9.5 to v1.11.3 to remove the warning
of protoc-gen-go/generator being deprecated.

Signed-off-by: Frank A. Zdarsky <fzdarsky@redhat.com>
@openshift-ci openshift-ci Bot requested review from husky-parul and rootfs October 26, 2021 12:42
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 26, 2021 •
edited
Loading

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: 7e645e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6177f79fad9e3b000704bc29

@oglok
Copy link
Copy Markdown
Contributor

oglok commented Oct 26, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

@fzdarsky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-apps 7e645e7 link false /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-api-machinery 7e645e7 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rootfs
Copy link
Copy Markdown
Contributor

rootfs commented Oct 27, 2021

CI test failures are not related to this PR
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@rootfs rootfs merged commit 2464be6 into main Oct 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@fzdarsky fzdarsky deleted the fix-366-generator-deprecated-warning branch October 27, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@husky-parul husky-parul Awaiting requested review from husky-parul

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@rootfs rootfs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Warning about old library: github.com/golang/protobuf/protoc-gen-go/generator

3 participants

@fzdarsky @oglok @rootfs