USHIFT-3778: Drop-in configuration directory#3792
USHIFT-3778: Drop-in configuration directory#3792openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
Conversation
|
@pmtk: This pull request references USHIFT-3778 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
approved
pmtk
force-pushed
the
drop-in-dir-cfg
branch
2 times, most recently
from
c6120c3 to
e9537fc
Compare
|
/retest |
There was a problem hiding this comment.
What if you want to save the current configuration because you want to replace entire bits of it? You would need this keyword (and others too) to achieve that, as drop in is an aggregate view and cant delete anything, right? (unless setting null values to parameters, but thats convoluted)
There was a problem hiding this comment.
Maybe, but that hasn't been the case in our tests. We start VMs with:
apiServer:
subjectAltNames:
- item1
- item2
And array are not being summed together, only overwritten.
There are two tests that overwrite the subjectAltNames: multi-nic.robot and validate-custom-certificates.robot and using drop-in with the SANs totally works.
There was a problem hiding this comment.
Un-deleted the keywords. Let's keep them for time being
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
pmtk
force-pushed
the
drop-in-dir-cfg
branch
from
a342a9c to
46f5808
Compare
There was a problem hiding this comment.
| - Support for config drop-in dir | |
| - Support for config drop-in directory |
There was a problem hiding this comment.
| [Documentation] Upload a new configuration file to the MicroShift host | |
| [Documentation] Remove a drop-in configuration file from MicroShift host |
There was a problem hiding this comment.
| [Documentation] Upload a new configuration file to the MicroShift host | |
| [Documentation] Upload a drop-in configuration file to the MicroShift host |
There was a problem hiding this comment.
| ${result} ${ignore}= Run Guest Process ${GUEST_NAME} rm /etc/microshift/config.d/10-hostname.yaml | |
| ${result} ${ignore}= Run Guest Process ${GUEST_NAME} rm -f /etc/microshift/config.d/10-hostname.yaml |
pmtk
force-pushed
the
drop-in-dir-cfg
branch
2 times, most recently
from
07f609e to
995fb1e
Compare
pmtk
force-pushed
the
drop-in-dir-cfg
branch
from
995fb1e to
f153370
Compare
|
/test ? |
|
@ggiguash: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal-bootc-periodic-test /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
No description provided.