Skip to content

Add precommit configuration and apply settings to files and fix typos#384

Closed
iranzo wants to merge 1 commit intoopenshift:mainfrom
iranzo:precommit
Closed

Add precommit configuration and apply settings to files and fix typos#384
iranzo wants to merge 1 commit intoopenshift:mainfrom
iranzo:precommit

Conversation

@iranzo
Copy link
Copy Markdown
Member

@iranzo iranzo commented Oct 27, 2021

This PR adds precommit as well as some of the opinionated formatters

  • fixes executable permissions on non-executable files
  • Add shebang on missing shell files
  • Fixes typos in spelling

@openshift-ci openshift-ci Bot requested review from mangelajo and sallyom October 27, 2021 10:54
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 27, 2021

✔️ Deploy Preview for microshift ready!

🔨 Explore the source changes: 154f363

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/61823a3662547f00085da897

😎 Browse the preview: https://deploy-preview-384--microshift.netlify.app

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

Hi @iranzo. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 27, 2021
@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented Oct 27, 2021

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2021
@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 28, 2021

/retest

1 similar comment
@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 28, 2021

/retest

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 28, 2021

/assign rootfs

@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented Oct 28, 2021

/test e2e-openshift-conformance-sig-api-machinery

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from rootfs after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Oct 29, 2021

Rebased on top of branch

@cooktheryan
Copy link
Copy Markdown
Contributor

I see no issues with this once its caught up sorry @iranzo for making you have to fix conflicts again

Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 3, 2021

@iranzo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-cli 154f363 link false /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-storage 154f363 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-api-machinery 154f363 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cooktheryan
Copy link
Copy Markdown
Contributor

@iranzo I'm singing 🎵 This is the PR that never ends....it just goes on and on my friend 🎵

@iranzo
Copy link
Copy Markdown
Member Author

iranzo commented Nov 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants