Fix copr integration#391
Merged
oglok merged 1 commit intoopenshift:mainfrom Oct 27, 2021
Merged
Conversation
It's called from the project root directory with make -f .copr/Makefile srpm outdir=... This means that we are already on the project root directory, otherwise this fails on copr with: ``` stdout: cd .. && make srpm make[1]: Entering directory '/mnt/workdir-8s69h1kn' make[1]: Leaving directory '/mnt/workdir-8s69h1kn' make[1]: *** No rule to make target 'srpm'. Stop. ``` Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
|
✔️ Deploy Preview for microshift canceled. 🔨 Explore the source changes: 82b54b4 🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/61797c34190cef0007e6e3a9 |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oglok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
thank you @oglok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's called from the project root directory with
make -f .copr/Makefile srpm outdir=...
This means that we are already on the project root directory,
otherwise this fails on copr with:
Signed-off-by: Miguel Angel Ajo majopela@redhat.com