update contributing doc#452
Conversation
|
Hi @osilkin98. Thanks for your PR. I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
|
/assign sallyom |
| directory where we will be storing the Vagrantfile. | ||
| MicroShift’s goal is to create a minimal core that can functionally operate as close to OpenShift as | ||
| possible while maintaining a low resource impact. We are always looking for enhancement proposals, | ||
| so feel free to create a pull-request and an additional document explaining your proposal. |
There was a problem hiding this comment.
Instead of opening a PR, they should create an enhancement issue with a link to a document that explains your proposal
Also, you can add
If the enhancement proposal aligns with [MicroShift's design goals]((https://github.com/redhat-et/microshift/blob/main/docs/design/design.md) it will be considered.
|
/LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cooktheryan, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
4 participants
Which issue(s) this PR addresses:
Closes #451