Skip to content

Add oc client binary to microshift-aio, set KUBECONFIG#481

Merged
fzdarsky merged 2 commits into
openshift:mainfrom
sallyom:oc-microshift-aio
Dec 6, 2021
Merged

Add oc client binary to microshift-aio, set KUBECONFIG#481
fzdarsky merged 2 commits into
openshift:mainfrom
sallyom:oc-microshift-aio

Conversation

@sallyom
Copy link
Copy Markdown
Contributor

@sallyom sallyom commented Dec 3, 2021

Which issue(s) this PR addresses:

Closes #474 #477

This oc 4.8.9 to the microshift-aio image from here

Also, sets KUBECONFIG within the microshift-aio image

@openshift-ci openshift-ci Bot requested review from fzdarsky and rootfs December 3, 2021 21:28
@sallyom sallyom changed the title Add oc client binary to microshift-aio Add oc client binary to microshift-aio, set KUBECONFIG Dec 3, 2021
@fzdarsky
Copy link
Copy Markdown
Contributor

fzdarsky commented Dec 6, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@fzdarsky fzdarsky merged commit f50c7a1 into openshift:main Dec 6, 2021
@thinkahead
Copy link
Copy Markdown

This is hardcoded to use amd64, it needs to be changed to use $ARCH. Also need to use newer OCP_VERSION that is available for aarch64

-RUN export OCP_VERSION=4.8.9 && \
-    curl -o oc.tar.gz https://mirror2.openshift.com/pub/openshift-v4/amd64/clients/ocp/$OCP_VERSION/openshift-client-linux-$OCP_VERSION.tar.gz && \
+RUN export OCP_VERSION=4.9.11 && \
+    curl -o oc.tar.gz https://mirror2.openshift.com/pub/openshift-v4/$ARCH/clients/ocp/$OCP_VERSION/openshift-client-linux-$OCP_VERSION.tar.gz && \

@sallyom
Copy link
Copy Markdown
Contributor Author

sallyom commented Dec 20, 2021

@thinkahead thanks for that! I've opened a PR, although, would also accept a PR from you. #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add oc client binary to microshift-aio

3 participants