Skip to content

move service-ca volumes to cm,secret#504

Merged
fzdarsky merged 1 commit into
openshift:mainfrom
sallyom:service-ca-operator-cm-secret
Dec 15, 2021
Merged

move service-ca volumes to cm,secret#504
fzdarsky merged 1 commit into
openshift:mainfrom
sallyom:service-ca-operator-cm-secret

Conversation

@sallyom
Copy link
Copy Markdown
Contributor

@sallyom sallyom commented Dec 15, 2021

Instead of hostPath volumes, create the configmap and secret to use configmap,secret volume type in service-ca deployment. This will allow service-ca pod to run as non-root, once the cluster-policy-controller is running in MicroShift.

@openshift-ci openshift-ci Bot requested review from fzdarsky and rootfs December 15, 2021 02:44
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2021

@sallyom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-reboot d9dcf58 link false /test e2e-reboot
ci/prow/e2e-openshift-conformance-sig-arch d9dcf58 link false /test e2e-openshift-conformance-sig-arch
ci/prow/e2e-openshift-conformance-sig-apps d9dcf58 link false /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-rpm-install d9dcf58 link false /test e2e-rpm-install
ci/prow/e2e-openshift-conformance-sig-network d9dcf58 link false /test e2e-openshift-conformance-sig-network
ci/prow/e2e-openshift-conformance-sig-cli d9dcf58 link false /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-api-machinery d9dcf58 link false /test e2e-openshift-conformance-sig-api-machinery
ci/prow/e2e-openshift-conformance-sig-storage d9dcf58 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-node d9dcf58 link false /test e2e-openshift-conformance-sig-node
ci/prow/e2e-openshift-conformance-sig-scheduling d9dcf58 link false /test e2e-openshift-conformance-sig-scheduling
ci/prow/e2e-openshift-conformance-sig-instrumentation d9dcf58 link false /test e2e-openshift-conformance-sig-instrumentation
ci/prow/e2e-openshift-conformance-sig-auth d9dcf58 link false /test e2e-openshift-conformance-sig-auth

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mangelajo
Copy link
Copy Markdown
Contributor

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@fzdarsky fzdarsky merged commit cabdaa1 into openshift:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants