Skip to content

OCPBUGS-60833: Fix router access logs container name #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Sep 3, 2025
Merged

OCPBUGS-60833: Fix router access logs container name #5368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ba1dc6
OCPBUGS-60833: Fix router access logs container name
pacevedom Aug 27, 2025
26fb612
OCPBUGS-60833: Fix router test container name
pacevedom Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/components/openshift-router/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ spec:
args:
- -v=4
{{- if and .AccessLoggingEnabled (not .AccessLoggingSyslogAddress) }}
- name: access-logs
- name: logs
imagePullPolicy: IfNotPresent
terminationMessagePolicy: FallbackToLogsOnError
image: '{{ .ReleaseImage.haproxy_router }}'
Expand Down
2 changes: 1 addition & 1 deletion scripts/auto-rebase/manifests_patches/011-ingress-deployment-access-logging.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ index 916e4b601..9261e3700 100644
args:
- -v=4
+ {{- if and .AccessLoggingEnabled (not .AccessLoggingSyslogAddress) }}
+ - name: access-logs
+ - name: logs
+ imagePullPolicy: IfNotPresent
+ terminationMessagePolicy: FallbackToLogsOnError
+ image: '{{ .ReleaseImage.haproxy_router }}'
Expand Down
2 changes: 1 addition & 1 deletion test/suites/router/router.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,5 +431,5 @@ Delete Custom CA Secret
Check Access Logs
[Documentation] Retrieve and check if a pattern appears in the router's access logs.
[Arguments] ${pattern}
${logs}= Oc Logs deployment/router-default -c access-logs openshift-ingress
${logs}= Oc Logs deployment/router-default -c logs openshift-ingress
Should Contain ${logs} ${pattern}