[release-4.20] USHIFT-6072: Add releases scenario for ISO and RPM deployment methods

assets/components/openshift-router/deployment.yaml

@@ -219,7 +219,7 @@ spec:
           args:
             - -v=4
         {{- if and .AccessLoggingEnabled (not .AccessLoggingSyslogAddress) }}
-        - name: access-logs
+        - name: logs
           imagePullPolicy: IfNotPresent
           terminationMessagePolicy: FallbackToLogsOnError
           image: '{{ .ReleaseImage.haproxy_router }}'

scripts/auto-rebase/manifests_patches/011-ingress-deployment-access-logging.patch

@@ -78,7 +78,7 @@ index 916e4b601..9261e3700 100644
            args:
              - -v=4
 +        {{- if and .AccessLoggingEnabled (not .AccessLoggingSyslogAddress) }}
-+        - name: access-logs
++        - name: logs
 +          imagePullPolicy: IfNotPresent
 +          terminationMessagePolicy: FallbackToLogsOnError
 +          image: '{{ .ReleaseImage.haproxy_router }}'

test/bin/common_versions.sh

@@ -136,7 +136,7 @@ export BREW_RC_RELEASE_VERSION
 export BREW_EC_RELEASE_VERSION
 
 # Set the release type to ec, rc or zstream
-LATEST_RELEASE_TYPE="rc"
+LATEST_RELEASE_TYPE="nightly"
 export LATEST_RELEASE_TYPE
 
 BREW_LREL_RELEASE_VERSION="${BREW_EC_RELEASE_VERSION}"
@@ -146,4 +146,4 @@ export BREW_LREL_RELEASE_VERSION
 OPENSHIFT_TESTS_PRIVATE_REPO_BRANCH="release-4.${MINOR_VERSION}"
 OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT="b6418066dc1c0fc55f8d0213792041770a0baf80"
 export OPENSHIFT_TESTS_PRIVATE_REPO_BRANCH
-export OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT
+export OPENSHIFT_TESTS_PRIVATE_REPO_COMMIT

test/bin/scenario.sh

@@ -894,13 +894,14 @@ configure_vm_firewall() {
 
 # Function to report the full version of locally built RPMs, e.g. "4.17.0"
 local_rpm_version() {
-    if [ ! -d "${LOCAL_REPO}" ]; then
+    REPO="${$1:-LOCAL_REPO}"
+    if [ ! -d "${REPO}" ]; then
         "${TESTDIR}/bin/build_rpms.sh"
     fi
 
-    local -r release_info_rpm=$(find "${LOCAL_REPO}" -name 'microshift-release-info-*.rpm' | sort | tail -n 1)
+    local -r release_info_rpm=$(find "${REPO}" -name 'microshift-release-info-*.rpm' | sort | tail -n 1)
     if [ -z "${release_info_rpm}" ]; then
-        error "Failed to find microshift-release-info RPM in ${LOCAL_REPO}"
+        error "Failed to find microshift-release-info RPM in ${REPO}"
         exit 1
     fi
     rpm -q --queryformat '%{version}-%{release}' "${release_info_rpm}" 2>/dev/null

test/image-blueprints-bootc/layer1-base/group3/rhel96-bootc-brew-ec-with-optional.image-bootc

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_EC_RELEASE_VERSION" "" -}}
+localhost/rhel96-bootc-brew-ec-with-optional:latest
+{{- end }}

test/image-blueprints-bootc/layer1-base/group3/rhel96-bootc-brew-nightly-with-optional.image-bootc

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_NIGHTLY_RELEASE_VERSION" "" -}}
+localhost/rhel96-bootc-brew-nightly-with-optional:latest
+{{- end }}

test/image-blueprints-bootc/layer1-base/group3/rhel96-bootc-brew-rc-with-optional.image-bootc

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_RC_RELEASE_VERSION" "" -}}
+localhost/rhel96-bootc-brew-rc-with-optional:latest
+{{- end }}

test/image-blueprints-bootc/layer1-base/group3/rhel96-bootc-brew-zstream-with-optional.image-bootc

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_Y0_RELEASE_VERSION" "" -}}
+localhost/rhel96-bootc-brew-zstream-with-optional:latest
+{{- end }}

test/image-blueprints/layer1-base/group5/rhel96-brew-ec-with-optionals.image-installer

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_EC_RELEASE_VERSION" "" -}}
+rhel-9.6-microshift-brew-optionals-4.{{ .Env.MINOR_VERSION}}-ec
+{{- end -}}

test/image-blueprints/layer1-base/group5/rhel96-brew-nightly-with-optionals.image-installer

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_NIGHTLY_RELEASE_VERSION" "" -}}
+rhel-9.6-microshift-brew-optionals-4.{{ .Env.MINOR_VERSION}}-nightly
+{{- end -}}

test/image-blueprints/layer1-base/group5/rhel96-brew-rc-with-optionals.image-installer

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_RC_RELEASE_VERSION" "" -}}
+rhel-9.6-microshift-brew-optionals-4.{{ .Env.MINOR_VERSION}}-rc
+{{- end -}}

test/image-blueprints/layer1-base/group5/rhel96-brew-zstream-with-optionals.image-installer

@@ -0,0 +1,3 @@
+{{- if env.Getenv "BREW_Y0_RELEASE_VERSION" "" -}}
+rhel-9.6-microshift-brew-optionals-4.{{ .Env.MINOR_VERSION }}-zstream
+{{- end -}}

test/resources/microshift-host.resource

@@ -99,6 +99,11 @@ Is System OSTree
     ...    sudo=True    return_stderr=False    return_stdout=False    return_rc=True
     IF    ${rc} == 0    RETURN    ${TRUE}    ELSE    RETURN    ${FALSE}
 
+System Should Not Be Ostree
+    [Documentation]    Make sure we run on a non-ostree system
+    ${is_ostree}=    Is System OSTree
+    Should Not Be True    ${is_ostree}
+
 System Should Be Rebooted
     [Documentation]    Assert if the system rebooted comparing the current and provided boot identifier
     [Arguments]    ${old_bootid}

test/resources/microshift-rpm.resource

@@ -107,3 +107,11 @@ Verify MicroShift RPM Install
 
     # Checks only config files from RPM packages excluding modification time check
     Command Should Work    rpm -qa microshift\* | xargs -I {} bash -c 'echo {}; sudo rpm -V --configfiles --nomtime {}'
+
+Pull Secret Should Be Installed
+    [Documentation]    Check that the kickstart file installed a pull secret for us
+    ${stdout}    ${stderr}    ${rc}=    SSHLibrary.Execute Command
+    ...    stat /etc/crio/openshift-pull-secret
+    ...    sudo=True    return_rc=True    return_stderr=True    return_stdout=True
+    Log Many    ${stdout}    ${stderr}
+    Should Be Equal As Integers    0    ${rc}

test/scenarios-bootc/releases/el96-lrel@standard1.sh

@@ -11,7 +11,7 @@ scenario_create_vms() {
     fi
 
     prepare_kickstart host1 kickstart-bootc.ks.template "${start_image}"
-    launch_vm --boot_blueprint rhel96-bootc
+    launch_vm --boot_blueprint "${start_image}"
 }
 
 scenario_remove_vms() {

test/scenarios-bootc/releases/el96-lrel@standard2.sh

@@ -11,7 +11,7 @@ scenario_create_vms() {
     fi
 
     prepare_kickstart host1 kickstart-bootc.ks.template "${start_image}"
-    launch_vm --boot_blueprint rhel96-bootc
+    launch_vm --boot_blueprint "${start_image}"
 }
 
 scenario_remove_vms() {

test/scenarios/presubmits/el96-src@rpm-install.sh

@@ -112,5 +112,7 @@ scenario_run_tests() {
         --variable "SOURCE_REPO_URL:${source_repo_url}" \
         --variable "TARGET_VERSION:${target_version}" \
         --variable "PREVIOUS_MINOR_VERSION:${PREVIOUS_MINOR_VERSION}" \
-        suites/rpm/install-and-upgrade-successful.robot
+        suites/rpm/install.robot \
+        suites/rpm/remove.robot \
+        suites/rpm/upgrade-successful.robot
 }

test/scenarios/releases/el96@rpm-install-upgrade.sh

@@ -0,0 +1,117 @@
+#!/bin/bash
+
+# Sourced from scenario.sh and uses functions defined there.
+
+# The RPM-based image used to create the VM for this test does not
+# include MicroShift or greenboot, so tell the framework not to wait
+# for greenboot to finish when creating the VM.
+export SKIP_GREENBOOT=true
+
+# NOTE: Unlike most suites, these tests rely on being run IN ORDER to
+# ensure the host is in a good state at the start of each test. We
+# could have separated them and run them as separate scenarios, but
+# did not want to spend the resources on a new VM.
+export TEST_RANDOMIZATION=none
+
+configure_microshift_mirror() {
+    local -r repo=$1
+
+    # `repo` might be empty if we install microshift from rhocp
+    if [[ -z "${repo}" ]] ; then
+        return
+    fi
+
+    # `repo` might be an enabled repo from a released version instead
+    # of a mirror.
+    if [[ ! "${repo}" =~ ^http ]]; then
+        return
+    fi
+
+    local -r tmp_file=$(mktemp)
+    tee "${tmp_file}" >/dev/null <<EOF
+[microshift-mirror-rpms]
+name=MicroShift Mirror
+baseurl=${repo}
+enabled=1
+gpgcheck=0
+skip_if_unavailable=0
+EOF
+    copy_file_to_vm host1 "${tmp_file}" "${tmp_file}"
+    run_command_on_vm host1 "sudo cp ${tmp_file} /etc/yum.repos.d/microshift-mirror-rpms.repo"
+    rm -f "${tmp_file}"
+}
+
+configure_rhocp_repo() {
+    local -r rhocp=$1
+    local -r version=$2
+
+    # The repository may be empty if the beta mirror is not up yet
+    if [[ -z "${rhocp}" ]] ; then
+        return
+    fi
+
+    if [[ "${rhocp}" =~ ^[0-9]{2} ]]; then
+        run_command_on_vm host1 "sudo subscription-manager repos --enable rhocp-4.${rhocp}-for-rhel-9-\$(uname -m)-rpms"
+    elif [[ "${rhocp}" =~ ^http ]]; then
+        local -r ocp_repo_name="rhocp-4.${version}-for-rhel-9-mirrorbeta-rpms"
+        local -r tmp_file=$(mktemp)
+
+        tee "${tmp_file}" >/dev/null <<EOF
+[${ocp_repo_name}]
+name=Beta rhocp RPMs for RHEL 9
+baseurl=${rhocp}
+enabled=1
+gpgcheck=0
+skip_if_unavailable=0
+EOF
+        copy_file_to_vm host1 "${tmp_file}" "${tmp_file}"
+        run_command_on_vm host1 "sudo cp ${tmp_file} /etc/yum.repos.d/${ocp_repo_name}.repo"
+        rm -f "${tmp_file}"
+    fi
+}
+
+scenario_create_vms() {
+    prepare_kickstart host1 kickstart-liveimg.ks.template ""
+    launch_vm 
+
+    # Open the firewall ports. Other scenarios get this behavior by
+    # embedding settings in the blueprint, but there is no blueprint
+    # for this scenario. We need do this step before running the RF
+    # suite so that suite can assume it can reach all of the same
+    # ports as for any other test.
+    configure_vm_firewall host1
+
+    # Register the host with subscription manager so we can install
+    # dependencies.
+    subscription_manager_register host1
+}
+
+scenario_remove_vms() {
+    remove_vm host1
+}
+
+scenario_run_tests() {
+    local -r reponame=$(basename "${BREW_REPO}")
+    local -r repo_url="${WEB_SERVER_URL}/rpm-repos/${reponame}"
+
+    # Enable the rhocp and dependency repositories.
+    #
+    # Note that rhocp or beta dependencies repository may not yet exist
+    # for the current version. Then, just use whatever we can get for
+    # the previous minor version.
+    configure_rhocp_repo "${RHOCP_MINOR_Y}"       "${MINOR_VERSION}"
+    configure_rhocp_repo "${RHOCP_MINOR_Y_BETA}"  "${MINOR_VERSION}"
+    configure_rhocp_repo "${RHOCP_MINOR_Y1}"      "${PREVIOUS_MINOR_VERSION}"
+    configure_rhocp_repo "${RHOCP_MINOR_Y1_BETA}" "${PREVIOUS_MINOR_VERSION}"
+    configure_microshift_mirror "${PREVIOUS_RELEASE_REPO}"
+    run_command_on_vm host1 "sudo subscription-manager repos --enable fast-datapath-for-rhel-9-\$(uname -m)-rpms"
+
+    run_tests host1 \
+        --exitonfailure \
+        --variable "SOURCE_REPO_URL:${repo_url}" \
+        --variable "TARGET_VERSION:${BREW_LREL_RELEASE_VERSION}" \
+        --variable "PREVIOUS_MINOR_VERSION:${PREVIOUS_MINOR_VERSION}" \
+        suites/rpm/install.robot \
+        suites/rpm/remove.robot \
+        suites/rpm/upgrade-successful.robot
+}