Pre-loading container images into CRI-O by husky-parul · Pull Request #568 · openshift/microshift

husky-parul · 2022-01-25T14:13:55Z

Signed-off-by: Parul parsingh@redhat.com

Which issue(s) this PR addresses:
Pre-loading container images into CRI-O

Closes #
#162

Should be merged after #593

husky-parul · 2022-02-01T16:12:09Z

/retest

husky-parul · 2022-02-01T17:41:37Z

/retest

husky-parul · 2022-02-22T19:32:18Z

@fzdarsky please TAL

fzdarsky · 2022-03-01T16:33:42Z

+Release: 1
+# this can be %{timestamp}.git%{short_hash} later for continous main builds
+Summary: Create custom container storage
+License: ASL 2.0


Is ASL the correct abbreviation (as it's Apache License not Apache Software Licence or such?

ASL is Apache Software License. Going to change it to AL 2.0

fzdarsky · 2022-03-01T16:39:25Z

+%build
+
+
+%install


Shouldn't this belong into the %build section, such that the RPM contains the images (rather than pulling them when installed)? Not sure the ImageBuilder can actually run stuff on podman when building ostrees.

As per the doc, https://rpm-packaging-guide.github.io/#what-is-a-spec-file

%build: Command or series of commands for actually building the software into machine code (for compiled languages) or byte code (for some interpreted languages).

%Install: Command or series of commands for copying the desired build artifacts from the %builddir (where the build happens) to the %buildroot directory (which contains the directory structure with the files to be packaged). This usually means copying files from ~/rpmbuild/BUILD to ~/rpmbuild/BUILDROOT and creating the necessary directories in ~/rpmbuild/BUILDROOT. This is only run when creating a package, not when the end-user installs the package. See [Working with SPEC files](https://rpm-packaging-guide.github.io/#working-with-spec-files) for details.

Since we are not building s/w and only using rpm to package files, I put it under %install

it's .spec files just being confusing,

What you expect for install is %post

%install is the phase that takes the %build, and put's it into the fake root filesystem,
from where %file will gather stuff.

Signed-off-by: Parul <parsingh@redhat.com>

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>

husky-parul · 2022-03-02T16:12:08Z

@mangelajo @fzdarsky
I understand make-microshift-images-rpm.sh will not create the .rpm for users images. Are we planning to keep two specs, one for microshift-images and one for users images?

mangelajo · 2022-03-03T13:52:43Z

+
+#Generate microshift-app-images.spec 
+touch ./microshift-app-images.spec
+cat >./microshift-app-images.spec <<EOF


We should probably propagate the changes from the other spec here.

But I propose we merge, and then we keep working on the userland side.

@mangelajo good idea. Could you open an issue for that please so we don't forget?

mangelajo · 2022-03-03T14:22:05Z

+URL: https://github.com/redhat-et/microshift
+
+BuildRequires: podman
+BuildRequires: crio


Suggested change

BuildRequires: crio

Requires: crio

mangelajo · 2022-03-03T14:55:30Z

#611
this will be necessary but can be independent of this patch.

Signed-off-by: Parul <parsingh@redhat.com>

openshift-ci · 2022-03-03T15:48:49Z

@husky-parul: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openshift-conformance-sig-network	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-network`
ci/prow/e2e-openshift-conformance-sig-auth	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-auth`
ci/prow/e2e-reboot	`f12cc6a`	link	false	`/test e2e-reboot`
ci/prow/e2e-openshift-conformance-sig-apps	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-apps`
ci/prow/e2e-openshift-conformance-sig-scheduling	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-scheduling`
ci/prow/e2e-openshift-conformance-sig-api-machinery	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-api-machinery`
ci/prow/e2e-openshift-conformance-sig-node	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-node`
ci/prow/e2e-openshift-conformance-sig-instrumentation	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-instrumentation`
ci/prow/e2e-openshift-conformance-sig-storage	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-storage`
ci/prow/e2e-openshift-conformance-sig-cli	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-cli`
ci/prow/e2e-openshift-conformance-sig-arch	`f12cc6a`	link	false	`/test e2e-openshift-conformance-sig-arch`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mangelajo · 2022-03-04T09:42:04Z

/lgtm

fzdarsky · 2022-03-04T09:58:50Z

/lgtm

openshift-ci · 2022-03-04T09:59:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [fzdarsky,mangelajo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

husky-parul added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2022

husky-parul self-assigned this Jan 25, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2022

husky-parul marked this pull request as draft January 25, 2022 14:14

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2022

openshift-ci Bot requested review from mangelajo and sallyom January 25, 2022 14:14

husky-parul force-pushed the imageloader branch from 0a6baa1 to c907eaf Compare January 25, 2022 14:58

husky-parul changed the title ~~image loader | initial drop~~ [WIP] Pre-loading container images into CRI-O Jan 25, 2022

husky-parul force-pushed the imageloader branch from c907eaf to 909e97e Compare January 25, 2022 15:05

husky-parul removed request for mangelajo and sallyom January 25, 2022 15:07

husky-parul force-pushed the imageloader branch 2 times, most recently from a1df000 to 8e44116 Compare February 1, 2022 15:07

husky-parul removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

husky-parul marked this pull request as ready for review February 1, 2022 15:51

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

openshift-ci Bot requested review from oglok and rootfs February 1, 2022 15:51

husky-parul force-pushed the imageloader branch 2 times, most recently from acbd9a0 to d6316a5 Compare February 1, 2022 15:57

husky-parul removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

husky-parul changed the title ~~[WIP] Pre-loading container images into CRI-O~~ Pre-loading container images into CRI-O Feb 1, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

husky-parul force-pushed the imageloader branch from d49d49f to 916b3c4 Compare February 1, 2022 17:58

copejon requested changes Feb 1, 2022

View reviewed changes

husky-parul added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2022

openshift-ci Bot requested review from cooktheryan and fzdarsky February 22, 2022 12:04

husky-parul requested review from copejon and mangelajo February 22, 2022 19:31

fzdarsky reviewed Mar 1, 2022

View reviewed changes

husky-parul and others added 4 commits March 2, 2022 11:09

microshift-images.spec for addtional ro container image stores.

475bcc9

Signed-off-by: Parul <parsingh@redhat.com>

create app images rpm spec

f2bae5b

Signed-off-by: Parul <parsingh@redhat.com>

rpmbuild fix strip

56c90ee

Signed-off-by: Parul <parsingh@redhat.com>

Multiarch support

1c0552a

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>

husky-parul force-pushed the imageloader branch from 45bdc55 to 1c0552a Compare March 2, 2022 16:09

mangelajo reviewed Mar 3, 2022

View reviewed changes

Comment thread packaging/rpm/microshift-images.spec

mangelajo reviewed Mar 3, 2022

View reviewed changes

Apache License 2.0

f12cc6a

Signed-off-by: Parul <parsingh@redhat.com>

openshift-ci Bot assigned mangelajo Mar 4, 2022

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2022

mangelajo requested review from fzdarsky and mangelajo March 4, 2022 09:42

openshift-ci Bot assigned fzdarsky Mar 4, 2022

fzdarsky merged commit 975561d into openshift:main Mar 4, 2022

mangelajo mentioned this pull request Mar 4, 2022

github ci pack containers mangelajo/microshift#5

Open

mangelajo mentioned this pull request Apr 12, 2022

kustomize dirs mangelajo/microshift#8

Closed

Conversation

husky-parul commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

husky-parul commented Feb 1, 2022

Uh oh!

husky-parul commented Feb 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

husky-parul commented Feb 22, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

husky-parul commented Mar 2, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mangelajo commented Mar 3, 2022

Uh oh!

openshift-ci Bot commented Mar 3, 2022

Uh oh!

mangelajo commented Mar 4, 2022

Uh oh!

fzdarsky commented Mar 4, 2022

Uh oh!

openshift-ci Bot commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

husky-parul commented Jan 25, 2022 •

edited

Loading