Make kube-proxy Service stoppable#574
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mangelajo
force-pushed
the
kube-proxy-stoppable
branch
from
dd0b062 to
298fdce
Compare
mangelajo
force-pushed
the
kube-proxy-stoppable
branch
from
298fdce to
660eff9
Compare
The kube-proxy k8s code does not support an stop channel, but at least we can accept cancel on the context and move on, so MicroShift can be stopped properly when necessary. Related-Issue: openshift#556 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo
force-pushed
the
kube-proxy-stoppable
branch
from
660eff9 to
ff937d6
Compare
|
@mangelajo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mangelajo
added
the
do-not-merge/work-in-progress
|
Being handled on another PR |
4 participants
The kube-proxy k8s code does not support an stop channel, but
at least we can accept cancel on the context and move on, so
MicroShift can be stopped properly when necessary.
Related-Issue: #556
Signed-off-by: Miguel Angel Ajo majopela@redhat.com