Skip to content

force packaging versions#594

Merged
cooktheryan merged 3 commits intoopenshift:mainfrom
cooktheryan:selinux
Feb 2, 2022
Merged

force packaging versions#594
cooktheryan merged 3 commits intoopenshift:mainfrom
cooktheryan:selinux

Conversation

@cooktheryan
Copy link
Copy Markdown
Contributor

@cooktheryan cooktheryan commented Feb 1, 2022

Signed-off-by: Ryan Cook rcook@redhat.com

Force set versions.

Output RHEL 8

Total                                                          79 MB/s |  36 MB     00:00     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                      1/1 
  Installing       : microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.noarch   1/2 
  Running scriptlet: microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.noarch   1/2 
  Installing       : microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.x86_64           2/2 
  Running scriptlet: microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.x86_64           2/2 
  Running scriptlet: microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.noarch   2/2 
  Running scriptlet: microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.x86_64           2/2 
  Verifying        : microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.x86_64           1/2 
  Verifying        : microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.noarch   2/2 
Installed products updated.

Installed:
  microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.x86_64                                  
  microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.el8.noarch                          

Complete!

Output Fedora 35

Importing GPG key 0x26DF568C:
 Userid     : "cooktheryan_microshift (None) <cooktheryan#microshift@copr.fedorahosted.org>"
 Fingerprint: 6075 9B78 E731 4E58 7E4F E878 AA94 B3E7 26DF 568C
 From       : https://download.copr.fedorainfracloud.org/results/cooktheryan/microshift/pubkey.gpg
Is this ok [y/N]: y
Key imported successfully
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                             1/1 
  Installing       : microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.noarch                         1/2 
  Running scriptlet: microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.noarch                         1/2 
libsemanage.semanage_direct_install_info: A higher priority microshift module exists at priority 400 and will override the module currently being installed at priority 200.

  Installing       : microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.x86_64                                 2/2 
  Running scriptlet: microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.x86_64                                 2/2 
Removed /etc/systemd/system/multi-user.target.wants/microshift.service.

  Running scriptlet: microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.noarch                         2/2 
  Running scriptlet: microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.x86_64                                 2/2 
  Verifying        : microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.x86_64                                 1/2 
  Verifying        : microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.noarch                         2/2 

Installed:
  microshift-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.x86_64                                                        
  microshift-selinux-4.8.0-2022_01_04_175420_24_g8a3819ee.fc35.noarch                                                

Complete!

Closes #473

@cooktheryan
force packaging versions
b7aedf5 
Signed-off-by: Ryan Cook <rcook@redhat.com>
@openshift-ci openshift-ci Bot requested review from copejon and husky-parul February 1, 2022 21:17
@cooktheryan cooktheryan requested review from mangelajo and removed request for husky-parul February 1, 2022 21:17
mangelajo
mangelajo reviewed Feb 2, 2022
View reviewed changes
Comment thread packaging/rpm/microshift.spec
@@ -269,4 +273,4 @@ mv /usr/lib/systemd/system/microshift-containerized.service /usr/lib/systemd/sys
- add missing BuildRequires on systemd and policycoreutils

Copy link
Copy Markdown
Contributor

@mangelajo mangelajo Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a packaging entry log here.

Please try it with make srpm it doesn't complain about the entrylog.

@mangelajo
Copy link
Copy Markdown
Contributor

mangelajo commented Feb 2, 2022

Awesome ryan!!! :-) thanks for looking on this.

@mangelajo
Copy link
Copy Markdown
Contributor

mangelajo commented Feb 2, 2022

image

works for me, but still there is some scriptlet error, the selinux warning goes away

@cooktheryan is there a way to check if the module was installed?

@cooktheryan
Copy link
Copy Markdown
Contributor Author

cooktheryan commented Feb 2, 2022

@mangelajo do semodule --list | grep microshift

@cooktheryan
Copy link
Copy Markdown
Contributor Author

cooktheryan commented Feb 2, 2022

@mangelajo did you have crio installed when you ran the above? I am not getting the scriptlet error on RHEL 8

@cooktheryan cooktheryan requested a review from mangelajo February 2, 2022 15:26
@cooktheryan
new packaging message
39e7472 
Signed-off-by: Ryan Cook <rcook@redhat.com>
@cooktheryan
Merge branch 'main' into selinux
66a0004
@mangelajo
Copy link
Copy Markdown
Contributor

mangelajo commented Feb 2, 2022

semodule --list | grep microshift
microshift

It's there.

I had crio installed. not sure what's going on but it's an improvement so let's merge IMHO.

I'll see if there's some way to debug the rpm install and figure that out.

@mangelajo
Copy link
Copy Markdown
Contributor

mangelajo commented Feb 2, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@cooktheryan cooktheryan merged commit 0481d4e into openshift:main Feb 2, 2022
@cooktheryan cooktheryan deleted the selinux branch February 2, 2022 18:00
@mangelajo mangelajo mentioned this pull request Mar 4, 2022
Open
@mangelajo mangelajo mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@mangelajo mangelajo Awaiting requested review from mangelajo

Assignees

@mangelajo mangelajo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] selinux RPM installation issues from copr

2 participants

@cooktheryan @mangelajo