Remove the microshift-containerized subpackage#595
Merged
cooktheryan merged 1 commit intoopenshift:mainfrom Feb 2, 2022
Merged
Remove the microshift-containerized subpackage#595cooktheryan merged 1 commit intoopenshift:mainfrom
cooktheryan merged 1 commit intoopenshift:mainfrom
Conversation
Our docs explain how to download the .service file [1] instead, and it has proven problematic to package this. Fix the microshift.service being overwritten by microshift-containerized, even when the non-containerized package only is installed. Resolves-Issue: openshift#591 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo
force-pushed
the
fix-microshift-service
branch
from
dd87e5e to
22f61dc
Compare
Contributor
Author
|
@fzdarsky it compiled properly now: |
Contributor
|
/LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cooktheryan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our docs explain how to download the .service file [1] instead,
and it has proven problematic to package this.
Fix the microshift.service being overwritten by microshift-containerized,
even when the non-containerized package only is installed.
Resolves-Issue: #591
Signed-off-by: Miguel Angel Ajo majopela@redhat.com