Install /etc/crio/crio.conf.d for containerized MicroShift#608
Merged
oglok merged 1 commit intoopenshift:mainfrom Mar 1, 2022
Merged
Install /etc/crio/crio.conf.d for containerized MicroShift#608oglok merged 1 commit intoopenshift:mainfrom
oglok merged 1 commit intoopenshift:mainfrom
Conversation
mangelajo
force-pushed
the
install-crio-conf-container
branch
2 times, most recently
from
1bd1683 to
a9b968f
Compare
Otherwise some containers start before the flannel setup is ready. This configuration guarantees that MicroShift. Fixes-Issue: openshift#605 Signed-off-by: Miguel Angel Ajo Pelayo <miguelangel@ajo.es>
mangelajo
force-pushed
the
install-crio-conf-container
branch
from
a9b968f to
064ec6c
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oglok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
loganmc10
reviewed
Mar 2, 2022
| COPY packaging/images/microshift/entrypoint.sh /root/entrypoint.sh | ||
|
|
||
| ENTRYPOINT ["/root/entrypoint.sh"] | ||
| CMD ["run"] |
There was a problem hiding this comment.
@mangelajo you should probably remove CMD ["run"]. I don't think it'll hurt anything, but it's passing "run" as an argument to entrypoint.sh, which would be ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise some containers start before the flannel setup is
ready. This configuration guarantees that MicroShift.
Fixes-Issue: #605
Signed-off-by: Miguel Angel Ajo Pelayo miguelangel@ajo.es
Which issue(s) this PR addresses:
Closes #605