Skip to content

[release-4.22] NO-JIRA: add Loki readiness check and restart logic to observability tests#6598

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-6589-to-release-4.22
Apr 29, 2026
Merged

[release-4.22] NO-JIRA: add Loki readiness check and restart logic to observability tests#6598
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-6589-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #6589

/assign agullon

…tests

Add a Loki readiness check (/ready endpoint) to the observability test
suite setup to detect when Loki's ingester has entered a shutdown state.
Automatically restart the Loki container if unhealthy, polling readiness
every 5s for up to 30s per attempt (3 attempts max) to cover the
ingester's ~15s warmup window.

- Add check_loki_ready() to loki.py with proper error handling
- Add restart action to manage_loki.sh script
- Fix IPv6 address handling in check_loki_query
- Split broad except Exception in check_loki_query into specific handlers

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cf36a9e8-7053-4325-b8a4-001bdcbdc352

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from copejon and vanhalenar April 28, 2026 11:19
@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/label jira/valid-bug
/label backport-risk-assessed
/lgtm
/verified by CI

@openshift-ci openshift-ci Bot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 28, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 28, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/label jira/valid-bug
/label backport-risk-assessed
/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/test e2e-aws-tests-release
/test e2e-aws-tests-release-arm
/test e2e-aws-tests-bootc-release-el9
/test e2e-aws-tests-bootc-release-el10
/test e2e-aws-tests-bootc-release-arm-el9
/test e2e-aws-tests-bootc-release-arm-el10

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/retest

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/test e2e-aws-tests-bootc-release-arm-el9

1 similar comment
@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/test e2e-aws-tests-bootc-release-arm-el9

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/test e2e-aws-tests-bootc-release-el9

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD d96b809 and 2 for PR HEAD 9d7bb64 in total

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/retest e2e-aws-tests-bootc-release-arm-el9

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/test e2e-aws-tests-bootc-release-arm-el9

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 28, 2026

/test e2e-aws-tests-periodic

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 29, 2026

/override ci/prow/e2e-aws-tests-bootc-release-el9
/override ci/prow/e2e-aws-tests-bootc-release-el10
/override ci/prow/e2e-aws-tests-bootc-release-arm-el9
/override ci/prow/e2e-aws-tests-bootc-release-arm-el10

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@agullon: Overrode contexts on behalf of agullon: ci/prow/e2e-aws-tests-bootc-release-arm-el10, ci/prow/e2e-aws-tests-bootc-release-arm-el9, ci/prow/e2e-aws-tests-bootc-release-el10, ci/prow/e2e-aws-tests-bootc-release-el9

Details

In response to this:

/override ci/prow/e2e-aws-tests-bootc-release-el9
/override ci/prow/e2e-aws-tests-bootc-release-el10
/override ci/prow/e2e-aws-tests-bootc-release-arm-el9
/override ci/prow/e2e-aws-tests-bootc-release-arm-el10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 29, 2026

/test e2e-aws-tests-periodic

1 similar comment
@agullon
Copy link
Copy Markdown
Contributor

agullon commented Apr 29, 2026

/test e2e-aws-tests-periodic

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-release-arm-el9 9d7bb64 link true /test e2e-aws-tests-bootc-release-arm-el9
ci/prow/e2e-aws-tests-bootc-release-arm-el10 9d7bb64 link true /test e2e-aws-tests-bootc-release-arm-el10
ci/prow/e2e-aws-tests-bootc-release-el10 9d7bb64 link true /test e2e-aws-tests-bootc-release-el10
ci/prow/e2e-aws-tests-bootc-release-el9 9d7bb64 link true /test e2e-aws-tests-bootc-release-el9

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 944b137 into openshift:release-4.22 Apr 29, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants