NO-ISSUE: rebase-release-5.0-5.0.0-0.nightly-2026-04-26-064718_amd64-2026-04-26_arm64-2026-04-28#6603
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughThis pull request updates ARM64 build artifacts for a newer OpenShift nightly release (2026-04-28-233705 replacing 2026-04-26-061912). Changes include bumped OCP versions, refreshed image digests across core components (multus, OLM, release images), updated Go dependencies, CRI-O configuration adjustments, and script enhancements for rebase automation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: inconsistent vendoring in :\n\tgithub.com/apparentlymart/go-cidr@v1.1.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/coreos/go-systemd@v0.0.0-20190321100706-95778dfbb74e: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/google/go-cmp@v0.7.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/miekg/dns@v1.1.63: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/openshift/api@v0.0.0-20260309155933-45fd88d185dd: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/openshift/build-machinery-go@v0.0.0-20251023084048-5d77c1a5e5af: is explicitly required in go.mod, but not marked as explicit ... [truncated 29519 characters] ... elet: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/metrics: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/mount-utils: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/pod-security-admission: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/sample-apiserver: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/sample-cli-plugin: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/sample-controller: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\n\tTo ignore the vendor directory, use -mod=readonly or -mod=mod.\n\tTo sync the vendor directory, run:\n\t\tgo mod vendor\n" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
openshift-ci
Bot
added
the
approved
pacevedom
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-bootc-arm-el9 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
etcd/go.mod (1)
7-19:⚠️ Potential issue | 🟡 MinorDependency bump: confirm
go.sum+ downstream compile/test coverage.Since
github.com/openshift/apiis bumped (line 8), please ensure the PR also updatesetcd/go.sumand thatgo mod tidydoesn’t re-order/alter dependencies unexpectedly.At minimum, in the
microshift/etcdmodule, run something like:
go mod tidygo test ./...If
go.sumchanges aren’t included, CI will often fail on verification steps.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@etcd/go.mod` around lines 7 - 19, The etcd/go.mod dependency for github.com/openshift/api was bumped but the corresponding etcd/go.sum and module hygiene may be missing; run go mod tidy in the microshift/etcd module to regenerate and update etcd/go.sum, ensure no unexpected reordering, then run go test ./... (or your CI test matrix) to verify compile/test coverage; include any go.sum changes in the PR before merging so CI's module verification passes.
🧹 Nitpick comments (1)
assets/optional/operator-lifecycle-manager/kustomization.aarch64.yaml (1)
19-24: Consider reducing digest duplication in patch values.
OPERATOR_REGISTRY_IMAGEandOLM_IMAGErepeat values already declared underimages; wiring these from a single source would reduce drift risk in future rebases.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@assets/optional/operator-lifecycle-manager/kustomization.aarch64.yaml` around lines 19 - 24, The patch hardcodes the same image digests for OPERATOR_REGISTRY_IMAGE and OLM_IMAGE that are already declared under images, causing duplication; update the kustomization so those env values are sourced from the single images declaration instead of repeating the digest: remove the hardcoded value fields in the patch that set OPERATOR_REGISTRY_IMAGE and OLM_IMAGE and replace them with references to the centralized image entries (use kustomize variable substitution or a replacement/transformer that maps the images entries to env vars) so OPERATOR_REGISTRY_IMAGE and OLM_IMAGE are populated from the images list rather than duplicate literals.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@etcd/go.mod`:
- Around line 7-19: The etcd/go.mod dependency for github.com/openshift/api was
bumped but the corresponding etcd/go.sum and module hygiene may be missing; run
go mod tidy in the microshift/etcd module to regenerate and update etcd/go.sum,
ensure no unexpected reordering, then run go test ./... (or your CI test matrix)
to verify compile/test coverage; include any go.sum changes in the PR before
merging so CI's module verification passes.
---
Nitpick comments:
In `@assets/optional/operator-lifecycle-manager/kustomization.aarch64.yaml`:
- Around line 19-24: The patch hardcodes the same image digests for
OPERATOR_REGISTRY_IMAGE and OLM_IMAGE that are already declared under images,
causing duplication; update the kustomization so those env values are sourced
from the single images declaration instead of repeating the digest: remove the
hardcoded value fields in the patch that set OPERATOR_REGISTRY_IMAGE and
OLM_IMAGE and replace them with references to the centralized image entries (use
kustomize variable substitution or a replacement/transformer that maps the
images entries to env vars) so OPERATOR_REGISTRY_IMAGE and OLM_IMAGE are
populated from the images list rather than duplicate literals.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: fe95e478-d75a-4f58-b882-61c2eb846d85
⛔ Files ignored due to path filters (3)
etcd/go.sumis excluded by!**/*.sumetcd/vendor/github.com/openshift/api/config/v1/types_authentication.gois excluded by!**/vendor/**etcd/vendor/modules.txtis excluded by!**/vendor/**
📒 Files selected for processing (12)
Makefile.version.aarch64.varassets/components/multus/kustomization.aarch64.yamlassets/components/multus/release-multus-aarch64.jsonassets/optional/operator-lifecycle-manager/kustomization.aarch64.yamlassets/optional/operator-lifecycle-manager/release-olm-aarch64.jsonassets/release/release-aarch64.jsonetcd/go.modpackaging/crio.conf.d/10-microshift_arm64.confscripts/auto-rebase/changelog.txtscripts/auto-rebase/commits.txtscripts/auto-rebase/last_rebase.shscripts/auto-rebase/rebase.sh
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@pacevedom: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pacevedom
deleted the
rebase-c8024efab-5.0.0-0.nightly-2026-04-26-064718_amd64-2026-04-26_arm64-2026-04-28
branch
3 participants
Summary by CodeRabbit
Chores
Bug Fixes