USHIFT-6744: Add sosreport and kcm related tests from OTP

[kasturinarra]

Summary by CodeRabbit

• Tests
  • Expanded OS configuration test execution to include additional OS config scenarios.
  • Added configuration tests for Kubernetes controller-manager verbose logging and OpenShift flavor flag verification.
  • Added a new SOS report plugin test suite to validate report generation, plugin enablement, collected contents, behavior under service stop, and cleanup.

[coderabbitai]

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new SOS report plugins Robot test suite, extends configuration tests with a KCM verbose-log-level test and setup/teardown, and updates the release scenario to include the new suite alongside systemd-resolved.robot in run_tests.

Changes

OS Configuration Testing + KCM Log VLevel

Layer / File(s)	Summary
Test Scenario Integration test/scenarios/releases/el98-lrel@osconfig.sh	run_tests invocation updated to include test/suites/osconfig/sos-report-plugins.robot in addition to systemd-resolved.robot.
New Test Suite test/suites/osconfig/sos-report-plugins.robot	New Robot test suite added with suite-level Setup/Teardown, variables, 4 test cases validating sos-report plugin listing, MicroShift/OVN data collection (including stopped MicroShift behavior), and Greenboot logs; includes keywords to create/extract/cleanup sos reports and assert plugin state.
KCM Data / Variable test/suites/configuration/configuration.robot	Adds ${KCM_LOG_VLEVEL} variable (YAML block with logVLevel: 2).
KCM Setup / Teardown test/suites/configuration/configuration.robot	Adds Setup KCM Log VLevel keyword to drop-in a KCM log-level config and restart MicroShift, and Teardown KCM Log VLevel to remove the drop-in and restart MicroShift.
KCM Test Case test/suites/configuration/configuration.robot	Adds test Verify KCM Runs With OpenShift Flavor Flags which sets KCM log vlevel, inspects kube-controller-manager flags in journal output against expected flavor flags, and performs teardown.
Teardown Integration test/suites/configuration/configuration.robot	Existing teardown updated to remove the 10-kcm-vlevel drop-in during cleanup.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the main changes: adding sosreport and kcm-related tests from OTP, which aligns with the three modified/added files (sos-report-plugins.robot, configuration.robot KCM tests, and test scenario updates).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Custom check targets Ginkgo test names. This PR contains only Robot Framework tests (.robot) and shell scripts (.sh), with no Ginkgo tests. Test names are stable and descriptive. Check not applicable.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test quality is not applicable. PR contains Robot Framework tests (.robot files) and shell scripts, not Ginkgo (Go) tests.
Microshift Test Compatibility	✅ Passed	This PR adds Robot Framework tests and shell scripts, not Ginkgo e2e tests. The MicroShift Test Compatibility check applies only to new Ginkgo tests and is therefore not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Custom check is not applicable. The PR adds Robot Framework tests (.robot) and shell scripts (.sh), not Ginkgo e2e tests. The check explicitly targets Ginkgo patterns (It, Describe, Context, When).
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only test files (Robot Framework suites and shell scripts). No deployment manifests, operator code, or controllers added. Check does not apply.
Ote Binary Stdout Contract	✅ Passed	Custom check "OTE Binary Stdout Contract" does not apply. PR modifies only Robot Framework test files and shell scripts, not Go process-level code (main, init, TestMain, suite setup).
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR adds Robot Framework test files (.robot), not Ginkgo Go e2e tests. The custom check applies only to Ginkgo tests (It(), Describe(), Context(), etc.). Check is not applicable to this PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@kasturinarra: This pull request references USHIFT-6744 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kasturinarra]

@CodeRabbit help

[coderabbitai]

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

CodeRabbit commands

These commands are invoked using PR/Issue comments.

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai rate limit to show your current review rate limit status.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai evaluate custom pre-merge check --instructions <custom-checks-instructions> --name <custom-checks-title> [--mode <error|warning>] to validate the custom pre-merge checks instructions. Defaults to error when --mode is omitted.
• @coderabbitai ignore pre-merge checks to override pre-merge checks and get an approval on PR.
• @coderabbitai run pre-merge checks to run pre-merge checks on the pull request.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve merge conflict to automatically resolve merge conflicts.
• @coderabbitai autofix to automatically fix issues identified in unresolved review comments.
• @coderabbitai resolve to resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai generate configuration to create a PR that adds the current resolved configuration as .coderabbit.yaml (or show it if already present).
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, support, documentation and community

• Visit our status page to check the current availability of CodeRabbit.
• Create a ticket on our support page for assistance with any issues or questions.
• Visit our documentation site for detailed information on how to use CodeRabbit.
• Join our Discord community to connect with other users and get help from the community.
• Follow us on X/Twitter for updates and announcements.

[kasturinarra]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[kasturinarra]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[openshift-ci]

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-tests-release	aaba151	link	true	/test e2e-aws-tests-release
ci/prow/e2e-aws-tests-bootc-el9	aaba151	link	true	/test e2e-aws-tests-bootc-el9
ci/prow/e2e-aws-tests-release-arm	aaba151	link	true	/test e2e-aws-tests-release-arm
ci/prow/e2e-aws-tests	aaba151	link	true	/test e2e-aws-tests
ci/prow/e2e-aws-tests-bootc-el10	aaba151	link	true	/test e2e-aws-tests-bootc-el10

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kasturinarra]

/retest

[kasturinarra]

/test e2e-aws-tests-release e2e-aws-tests-bootc-el9 e2e-aws-tests-release-arm e2e-aws-tests e2e-aws-tests-bootc-el10