Skip to content

Conversation

@mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Jun 10, 2022

Remove stray klog format %s

Signed-off-by: Miguel Angel Ajo Pelayo <miguelangel@ajo.es>
@openshift-ci openshift-ci bot requested review from copejon and dhellmann June 10, 2022 12:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@dhellmann
Copy link
Contributor

D'oh! Thanks for catching that.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dhellmann,mangelajo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5511897 into openshift:main Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@mangelajo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mangelajo
Copy link
Contributor Author

mangelajo commented Jun 10, 2022

D'oh! Thanks for catching that.

/lgtm

Thanks for all the cleanups! :)

I believe we used to have a linter in GitHub CI may be, we should add it on openshift CI

@dhellmann
Copy link
Contributor

I believe we used to have a linter in GitHub CI may be, we should add it on openshift CI

Yes, definitely. Many repos do run a linter, so we should have example jobs we can work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants