Skip to content

USHIFT-112: RPM images script command line enhancement and pull secret usage#748

Merged
openshift-ci[bot] merged 3 commits intoopenshift:mainfrom
ggiguash:rpm_images_pull_request
Jun 30, 2022
Merged

USHIFT-112: RPM images script command line enhancement and pull secret usage#748
openshift-ci[bot] merged 3 commits intoopenshift:mainfrom
ggiguash:rpm_images_pull_request

Conversation

@ggiguash
Copy link
Copy Markdown
Contributor

@ggiguash ggiguash commented Jun 27, 2022

  • Add better command line support to make-microshift-images-rpm.sh script
  • Pull secret needs to be specified when creating RPMs

Partial implementation of USHIFT-112

@openshift-ci openshift-ci Bot requested review from copejon and oglok June 27, 2022 09:21
@ggiguash
Copy link
Copy Markdown
Contributor Author

/assign @sallyom

Comment thread packaging/rpm/make-microshift-images-rpm.sh Outdated
@ggiguash ggiguash requested a review from dhellmann June 28, 2022 13:29
@dhellmann
Copy link
Copy Markdown
Contributor

dhellmann commented Jun 28, 2022

I've been told that if we refer to a Jira ticket in a PR description there's a bot that will add a link on the Jira ticket. I'm using this PR to experiment with that.

/retitle USHIFT-112: RPM images script command line enhancement and pull secret usage

@openshift-ci openshift-ci Bot changed the title RPM images script command line enhancement and pull secret usage USHIFT-112: RPM images script command line enhancement and pull secret usage Jun 28, 2022
@ggiguash
Copy link
Copy Markdown
Contributor Author

@dhellmann

I've been told that if we refer to a Jira ticket in a PR description there's a bot that will add a link on the Jira ticket. I'm using this PR to experiment with that.
Note that a link to the JIRA issue had already been there in the description before you changed the title.

@dhellmann
Copy link
Copy Markdown
Contributor

@dhellmann

I've been told that if we refer to a Jira ticket in a PR description there's a bot that will add a link on the Jira ticket. I'm using this PR to experiment with that.
Note that a link to the JIRA issue had already been there in the description before you changed the title.

Yes, I didn't see the link to the PR on the Jira ticket initially. I'm not sure if it was there because the reference in the description is a link, not just the ticket ID.

@ggiguash
Copy link
Copy Markdown
Contributor Author

@dhellmann, generally, it does not matter where you put the JIRA issue ID: description, title or comment - the bot creates the link between the JIRA issue and the PR.

@ggiguash
Copy link
Copy Markdown
Contributor Author

/retest

@ggiguash
Copy link
Copy Markdown
Contributor Author

/retest

@dhellmann
Copy link
Copy Markdown
Contributor

/approve

I verified that this script works following the instructions in #750

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented Jun 30, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2022

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants