Skip to content

USHIFT-19: add example config file to rpm#914

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-19-default-config-in-rpm
Sep 1, 2022
Merged

USHIFT-19: add example config file to rpm#914
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-19-default-config-in-rpm

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

Add /etc/microshift/microshift.yaml with the current defaults,
all commented out.

Closes #663

Add /etc/microshift/microshift.yaml with the current defaults,
all commented out.

Fixes openshift#663

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@openshift-ci openshift-ci Bot requested review from ggiguash and pmtk August 31, 2022 18:32
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@dhellmann
Copy link
Copy Markdown
Contributor Author

/cc @fzdarsky

@openshift-ci openshift-ci Bot requested a review from fzdarsky August 31, 2022 18:34
install -p -m644 packaging/systemd/microshift.service %{buildroot}%{_unitdir}/microshift.service

install -d -m755 %{buildroot}/%{_sysconfdir}/microshift
install -p -m644 packaging/microshift/microshift.yaml %{buildroot}%{_sysconfdir}/microshift/microshift.yaml
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure whether to install the file to the real location or to an "example.yaml" location. I decided to go for the real location, but I'm open to changing that.

@dhellmann
Copy link
Copy Markdown
Contributor Author

/type documentation

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Sep 1, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 1, 2022

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 95deaf9 into openshift:main Sep 1, 2022
dhellmann added a commit to dhellmann/microshift that referenced this pull request Sep 1, 2022
Fixes an issue introduced in openshift#914
Related to openshift#663

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USHIFT-19: Ship default config file in rpm

3 participants