Skip to content

add etcd shim to microshift until we package proper etcd separately#992

Closed
deads2k wants to merge 2 commits intoopenshift:mainfrom
deads2k:etcd-shim
Closed

add etcd shim to microshift until we package proper etcd separately#992
deads2k wants to merge 2 commits intoopenshift:mainfrom
deads2k:etcd-shim

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Oct 4, 2022

this will allow microshift etcd to behave like a standalone etcd process so we can start merging PRs that run a transient systemd unit before packaging is complete.

/assign @dusk125

@openshift-ci openshift-ci Bot requested review from pmtk and stlaz October 4, 2022 16:56
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
Once this PR has been reviewed and has the lgtm label, please assign mangelajo for approval by writing /assign @mangelajo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 4, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Oct 10, 2022

included in #976

@deads2k deads2k closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants