Skip to content

OCPBUGS-28230: enforce termination message policy on all platform pods#227

Closed
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:termination
Closed

OCPBUGS-28230: enforce termination message policy on all platform pods#227
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:termination

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Apr 12, 2024

This will include the last few log lines on container crashes to assist in debugging.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 12, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This will include the last few log lines on container crashes to assist in debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from dcbw and dougbtv April 12, 2024 18:22
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
Once this PR has been reviewed and has the lgtm label, please assign dcbw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 12, 2024

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@s1061123
Copy link
Copy Markdown
Contributor

@deads2k thank you for the PR, but these files are not used in OCP, actually. These files are just copied from upstream's example yaml and actual files is in cluster network operator. Your CNO's PR(openshift/cluster-network-operator#2224) already cares of that, so if you don't mind it, I'd like to close this PR.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 15, 2024

@deads2k thank you for the PR, but these files are not used in OCP, actually. These files are just copied from upstream's example yaml and actual files is in cluster network operator. Your CNO's PR(openshift/cluster-network-operator#2224) already cares of that, so if you don't mind it, I'd like to close this PR.

Cool, thanks.

@deads2k deads2k closed this Apr 15, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This will include the last few log lines on container crashes to assist in debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants