-
Notifications
You must be signed in to change notification settings - Fork 13
CNV-66757: Redesign NodeNetworkConfigurationPolicy wizard #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-66757: Redesign NodeNetworkConfigurationPolicy wizard #111
Conversation
|
@pcbailey: This pull request references CNV-66757 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.20." or "openshift-4.20.", but it targets "CNV v4.21.0" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
19df44f to
68fe4b0
Compare
68fa418 to
9198422
Compare
9198422 to
530478d
Compare
src/utils/components/PolicyForm/PolicyWizard/steps/NetworkIdentity/NetworkIdentity.scss
Outdated
Show resolved
Hide resolved
...s/components/PolicyForm/PolicyWizard/steps/NodesConfigurationStep/NodesConfigurationStep.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/PolicyForm/PolicyWizard/steps/NetworkIdentity/NetworkIdentity.tsx
Outdated
Show resolved
Hide resolved
30a1c2b to
a332e22
Compare
|
/retest |
28a4a83 to
69b95c2
Compare
...zard/steps/UplinkConnectionStep/components/SingleInterfaceContent/SingleInterfaceContent.tsx
Outdated
Show resolved
Hide resolved
69b95c2 to
3e1258e
Compare
|
/retest |
3e1258e to
da6f08b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-tests |
|
@upalatucci: Overrode contexts on behalf of upalatucci: ci/prow/e2e-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pcbailey: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a redesign of the existing NNCP wizard.
Jira: https://issues.redhat.com/browse/CNV-66757