CNV-62004: Remove default bridge interface step. Enhance add interface label #116
Conversation
|
@galkremer1: This pull request references CNV-62004 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
| name: 'policy-name', | ||
| }, | ||
| spec: { | ||
| desiredState: { |
There was a problem hiding this comment.
Removed default interface
| {t(`Add ${noCurrentStepInterfaces ? '' : 'another '}{{label}} interface`, { | ||
| label: label.toLowerCase(), | ||
| })} |
There was a problem hiding this comment.
this will not be translated correctly. You should have two distinct translations here.
There was a problem hiding this comment.
I added another translation. Did I miss anything?
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: galkremer1, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@galkremer1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Jira: https://issues.redhat.com/browse/CNV-62004
interfaceTypeinterface" label to "AddinterfaceTypeinterface" when no interfaces are currently present (see demo below).Demo:
Screen.Recording.2025-09-10.at.12.39.14.PM.mov