Skip to content

[WIP] remove missing conversion webhook#50

Closed
tkashem wants to merge 1 commit intoopenshift:mainfrom
tkashem:fix-conversion-webhook
Closed

[WIP] remove missing conversion webhook#50
tkashem wants to merge 1 commit intoopenshift:mainfrom
tkashem:fix-conversion-webhook

Conversation

@tkashem
Copy link

@tkashem tkashem commented Aug 27, 2024

Testing if this removes the broken conversion webhook: openshift/origin#29003 (comment)

image

the source webhook.openshift-console-operator.svc:9443 shows permanent error, looks to be a bad conversion webhook?

2024-08-16T21:24:15.202127907Z W0816 21:24:15.202025      14 reflector.go:547] storage/cacher.go:/console.openshift.io/consoleplugins: failed to list console.openshift.io/v1alpha1, Kind=ConsolePlugin: conversion webhook for console.openshift.io/v1, Kind=ConsolePlugin failed: Post "https://webhook.openshift-console-operator.svc:9443/crdconvert?timeout=30s": service "webhook" not found

openshift/api@99bfe92 removed the conversion webhook from the API

Not sure if the conversion webhook in the schema (in this repo) is causing this, this proof PR will reveal

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@tkashem
Copy link
Author

tkashem commented Aug 27, 2024

/hold

(we want to write a test that detects a faulty webhook and outputs a flaky test before we merge it)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2024
@openshift-ci openshift-ci bot requested review from pcbailey and yaacov August 27, 2024 15:00
@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tkashem
Once this PR has been reviewed and has the lgtm label, please assign metalice for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Author

tkashem commented Aug 28, 2024

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2024

@tkashem: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-tests
  • /test images

Use /test all to run all jobs.

Details

In response to this:

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tkashem
Copy link
Author

tkashem commented Aug 28, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2024

@tkashem: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2024
@avivtur
Copy link

avivtur commented Dec 22, 2024

Hi @tkashem
Any news on this?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 22, 2025
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Feb 21, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2025

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants