[wip] add missing sysfs bits to netlink exporter#123
[wip] add missing sysfs bits to netlink exporter#123dcbw wants to merge 2 commits intoopenshift:masterfrom dcbw:netlink-sysfs
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dcbw The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@dcbw can you provide more details about this PR? Do you want to test-drive the change with the intent of bringing it upstream eventually? cc @raptorsun |
|
ok disregard my previous comment, I've got the context now :) |
Read dev_id, name_assign_type, and addr_assign_type from sysfs anyway, since they only take a device-specific lock and not the whole RTNL lock. This means they are much less impactful to read on other system processes. Signed-off-by: Dan Williams <dcbw@redhat.com>
|
@dcbw: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Moved upstream to prometheus#2669 |
2 participants
No description provided.