AWS BSL should allow empty region

[kaovilai]

Describe the bug

AWS BSL cannot have empty region. This is not how it should be according to BSL docs for aws plugin
Region can be queried from aws s3 api or not needed through means such as s3Url

To Reproduce
Steps to reproduce the behavior:
Create Velero CR with region empty

Expected behavior
Velero reconcile

Provide the following logs
Got error reconcile condition on velero object.
region for AWS backupstoragelocation config cannot be empty

Version of operator being used

• 0.3.0

Additional context
Fix by changing the following

oadp-operator/controllers/bsl.go

Lines 144 to 146 in 5a5d443

	if len(bslSpec.Config[Region]) == 0 {
	return fmt.Errorf("region for AWS backupstoragelocation config cannot be empty")
	}

[dymurray]

This validation logic should be changed to check if a region is not specified, the user must supply s3Url. If s3Url and region are missing, then it should fail and display the error.

[shubham-pampattiwar]

We do not need s3Url as well. Both are optional. The AWS BSL can be created with just specifying the bucket and nothing in the config spec. We need the region for registry deployment though. So more like the region validation for AWS BSL should be modified to be called only for B/R of images velero.Spec.BackupImages == nil || *velero.Spec.BackupImages) . This will be same as the prefix validation I believe https://github.com/openshift/oadp-operator/blob/v0.3.0/controllers/bsl.go#L148